Enhance sandbox component to accept sandbox prop #69617
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks, @Imran92! The https://github.com/Automattic/videopress/issues/1217 link leads to 404 packages. Please don't use private links or dead links for other repositories as references. |
|
Thanks @Mamaduka , I've removed the links |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enhances the Sandbox component
Why?
The iFrame in the sandbox component does not have
allow-popupsin its sandbox value. Because of this, when we show any content inside the sandbox that has a link, does not take users anywhere when they click on it, because it gets blocked.Instead of hard-coding the sandbox value, we've just made it configurable, and it's optional. So it will not disrupt any place it's being used in.
Our actual goal is to use it in the Jetpack repo to fix the VP blocks. Jetpack consumes the NPM library @wordpress/components. So we'll need to release it on NPM before moving on with the next part of the fix.
How?
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A