BlockBreadcrumb: Wrap text node in span tag #69605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: +2 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
The change/fix looks harmless, so it's okay to merge.
P.S. The code in question was introduced four years ago (#32528), so either folks aren't using Google Translate with block editor, or there's a change in G translate code.
@adamsilverstein or @swissspidy, you might know better what the right approach is here.
|
Thanks for the review! After some more research, I discovered that this problem is more complicated than I thought. On approach seems to wrap the text node in some kind of tag, as in this PR, but there doesn't seem to be an ideal solution yet. References: |
|
Let's merge this for now. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* BlockBreadcrumb: Wrap text node in span tag * Update snapshot Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org> Co-authored-by: Robertght <robertghetau@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Wrap the text node in the
BlockBreadcrumbcomponent with a span tagCloses #69597
Why?
The error that occurs is the following:
Probably, the translation feature of the Chrome browser dynamically updates the text nodes on the page, which causes the React DOM tree to get out of sync with the actual DOM tree.
How?
Simply wrap the conditionally-rendered text node in a span tag.
Testing Instructions
Screenshots or screencast
Before
2b883f92bb4be1d50f322aa05fe432b5.mp4
After
fb32184ed00de4ad5d7ec0d80ab1ece2.mp4