Site Editor: Make the text "Custom Styles" translatable #69677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
ae7cf4f to
8e1a4c6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Note: The milestone for the core ticket has been changed to 6.8, but this issue isn't new to 6.8. I don't have a strong opinion, but it might be nice to backport to 6.8. |
|
This looks good to me. |
audrasjb
approved these changes
Mar 24, 2025
It's probably a safe change, but I'm leaning towards not backporting it to 6.8 to be on the safe side. I looked into this issue and found that it's been around since at least 6.3, so I think there's no need to rush it 😅 Screenshots from 6.3: |
|
Alright I moved the related Trac ticket to milestone 6.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes https://core.trac.wordpress.org/ticket/63150
This PR applies the translate function to the text "Custom Styles" in the pre-publish sidebar in the site editor.
Why?
In the site editor, there is the pre-save panel that shows dirty entities, such as templates, template parts, global styles, etc.
The global styles is a kind of a post, so the
post_titlefield is referenced. As you can see in https://core.trac.wordpress.org/changeset/52282, this title is not translatable because the hard-coded English text is stored in the database.How?
In the root entities config, update the
getTitle()function so that it can get the translated text. My understanding is that this title is not used anywhere else except in the pre-save panel, so it should be fine to always return the translated text.Testing Instructions
We can't test this PR for now, because the text is not localized yet in all languages. However, you can temporarily change the text to test whether the context is really reflected in the panel.