-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Modify the AnglePickerControl example code. #69673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the AnglePickerControl example code. #69673
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you confirm the following points?
- Run
docs:components
: The README of this component is auto-generated from the example code. - Rebase this PR: This should fix the e2e test failure. See #69669
Thanks for the review! I've adjusted it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your kind review! |
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Modify the AnglePickerControl example code.
Why?
Since the
AnglePickerControl
component does not have Children,/>
is correct, not</>
.You can see that syntax highlighting is also working correctly.
Screenshots or screencast
Labels
[Package] Components
[Type] Developer Documentation