Skip to content

Modify the AnglePickerControl example code. #69673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shimotmk
Copy link
Contributor

What?

Modify the AnglePickerControl example code.

Why?

Since the AnglePickerControl component does not have Children, /> is correct, not </>.

You can see that syntax highlighting is also working correctly.

Screenshots or screencast

Before After
before after

Labels
[Package] Components
[Type] Developer Documentation

@shimotmk shimotmk requested a review from ajitbohra as a code owner March 24, 2025 09:20
Copy link

github-actions bot commented Mar 24, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Mar 24, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you confirm the following points?

  • Run docs:components: The README of this component is auto-generated from the example code.
  • Rebase this PR: This should fix the e2e test failure. See #69669

@shimotmk
Copy link
Contributor Author

Thanks for the review! I've adjusted it.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mamaduka Mamaduka merged commit 2fa0eff into WordPress:trunk Mar 24, 2025
58 of 59 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 24, 2025
@shimotmk
Copy link
Contributor Author

Thank you for your kind review!

@shimotmk shimotmk deleted the fix/components-angle-picker-controll--docs branch March 24, 2025 20:58
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants