Skip to content

Developer Documentation: Update VS Code settings in contribution guide #69670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Mar 24, 2025

What?

Closes: N/A - Doc improvement submitted directly as PR.
Updates the ESLint code actions on save configuration example from boolean value (true) to string value ("explicit").

Why?

VS Code shows warnings when using boolean values and recommends string values for better clarity. This change aligns with VS Code's latest guidance as documented in their refactoring guide and implemented in VS Code PR #201808.

@im3dabasia im3dabasia marked this pull request as ready for review March 24, 2025 06:26
Copy link

github-actions bot commented Mar 24, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you rebase this PR in order to fix CI failures?

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Mar 24, 2025
@im3dabasia im3dabasia force-pushed the fix/doc-code-contribute-guide branch from 81b4d6a to f83af26 Compare March 24, 2025 11:09
@im3dabasia im3dabasia requested a review from t-hamano March 24, 2025 11:11
@im3dabasia
Copy link
Contributor Author

@t-hamano ,

I believe the CI tests are now passing and its safe to merge this change. 🚀 🚀

@t-hamano t-hamano merged commit f90f754 into WordPress:trunk Mar 24, 2025
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 24, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants