Skip to content

Conversation

karthikeya-io
Copy link
Contributor

What?

Part of #69646

This PR introduces theming support for Toolbar component

Why?

Previously the Toolbar component lacks theming support and hard to read particularly in the dark-mode.

How?

Testing Instructions

Run storybook locally. (npm run storybook:dev)
Navigate to the Toolbar component.
Change the theme and confirm that there are no visibility issues.

Testing Instructions for Keyboard

Same

Screenshots or screencast

Default theme

Before After
image image

Dark theme

Before After
image image

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 21, 2025
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthikeya-io! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@karthikeya-io karthikeya-io marked this pull request as ready for review March 21, 2025 17:49
Copy link

github-actions bot commented Mar 21, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: [Focus] Accessibility (a11y), [Package] Components, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Mar 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthikeya-io <karthikeya01@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo
Copy link
Contributor

ciampo commented Mar 24, 2025

Let's wait for design feedback on that look should the toolbar have on dark themes (cc @WordPress/gutenberg-design )

@t-hamano t-hamano added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Mar 25, 2025
@t-hamano
Copy link
Contributor

@karthikeya-io Thanks for the PR!

Sorry, a similar PR (#69278) has already been submitted, so let me close this PR.

However, we appreciate your work!

@t-hamano t-hamano closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants