Classic theme site preview: Make all interactive elements unclickable #69522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: -19 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Thanks, @t-hamano!
The fix works as expected ✅
I noticed that users are still able to select text in iframe. Is this intentional? Have we considered setting the inert attribute for iframe body?
cc @afercia
|
Flaky tests detected in f4fb1ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13779973440
|
The inert attribute would also remove elements from the accessibility tree, they would not be exposed to assistive technoloiges any longer. Users would not be able tp 'read' the content with |
|
Thanks for the review! Based on the feedback, it seems best to not use the |
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 11, 2025
…#69522) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 6c75f56 |
This was referenced May 4, 2025
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#69522) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Found while working on #69474
This PR makes "all" interactive elements unclickable in the classic theme site preview.
Why?
The current logic doesn't make interactive all elements unclickable. For example, textarea, content editable div, div element with tabindex="0":
996d390392ee268e37d74e98acb72df2.mp4
How?
Use
focus.focusablemethod from@wordpress/dompackage to check all interactive elements.Testing Instructions