-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Document Outline: Disable selection for non-content headings #69506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Outline: Disable selection for non-content headings #69506
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +129 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame there needs to be an additional check depending on the editing mode.
✅ It solves the problem with selecting the template blocks that are not editable.
Yeah, realized that last moment. Design post types ( IMO, it should be okay for now. |
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: ac743d9 |
…ss#69506) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
What?
Closes #69347.
PR prevents selecting heading blocks from a template when the editor renders in
template-locked
mode.I've re-introduced the disabled state for document outline items (#14081). The disabled items cannot be selected and are lighter grey in color. The design changes are minimal; I tried to match existing design patterns.
Why?
Blocks outside post content can't be edited or selected when viewing in
template-locked
mode.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast