REST API: Add additional default template data fields for the active theme #69417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -49 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
This looks like the right approach to me. Thanks @Mamaduka! Just a note, we do need to correct the schemas. |
There was a problem hiding this comment.
This looks like a good approach to me.
I've confirmed admins can see the results on /themes and that authors can see the results on /themes/theme-slug.
For classic themes without a result, both of the values are null, block themes return an array of template types and parts.
Thanks for your patience as we worked through this, I appreciate it.
peterwilsoncc
approved these changes
Mar 6, 2025
|
Tested this PR, and it’s working well for me. Thanks, @Mamaduka |
35ad5f1 to
1d15338
Compare
|
Updated the schema and am going to merge this as soon as CI checks are passing. |
|
Flaky tests detected in dd46d92. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13757558412
|
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 10, 2025
…theme (#69417) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: TimothyBJacobs <timothyblynjacobs@git.wordpress.org> Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 18bf6a5 |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…theme (WordPress#69417) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: TimothyBJacobs <timothyblynjacobs@git.wordpress.org> Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69195.
Fixes https://core.trac.wordpress.org/ticket/63055.
PR changes the method for exposing
default_template_typesanddefault_template_part_areasdata via REST API. This data is now provided as additional fields for the active theme and consumed using thegetCurrentThemeselector.Why?
It is based on the recent discussion in the core sync ticket - https://core.trac.wordpress.org/ticket/62574#comment:29.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast