Site Editor Sidebar: Fix header scrolling in mobile layout #69413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -43 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
commented
Mar 5, 2025
| height: calc(100% - #{$header-height}); | ||
| height: 100%; |
There was a problem hiding this comment.
If we do not change this to 100%, there will be space at the bottom of the page screen:
Originally, this height was added to prevent unintended scrolling in the mobile layout.
However, now that the mobile layout matches its desktop counterpart, it's no longer necessary to subtract the header height. See #64844 (review)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
6 tasks
|
@stokesman Thanks for the review! |
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 6, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 1c7d109 |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…#69413) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69328
This PR separates the
SidebarContentcomponent from the context provider.This will bring the sidebar HTML structure closer to consistency between desktop and mobile. As a result, this should ideally resolve the issue reported in #69328.
How?
Separate the context provider from
SidebarContentand extract it into a standalone component. This results in the following HTML structure in the mobile layout:This structure closely matches the desktop one:
Note
This is a fix for 6.8. In the future the context may not be needed at all. See #69172
Testing Instructions
Screenshots or screencast
GIFs to confirm that #69328 has been fixed: