Skip to content

Search: wp-block-search__inside-wrapper classname trailing spaces #69405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2025
Merged

Search: wp-block-search__inside-wrapper classname trailing spaces #69405

merged 4 commits into from
Apr 2, 2025

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Mar 4, 2025

What?

Include trimming in Search to make it more consistent with other blocks

Similar #68161 #68880

Testing Instructions

  1. Open a post or page.
  2. Insert a Search block.
  3. The space after the class of wp-block-search__inside-wrapper is disappearing.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before after

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Block] Search Affects the Search Block - used to display a search field labels Mar 4, 2025
Mamaduka
Mamaduka approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shimotmk!

@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Apr 2, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Apr 2, 2025
@Mamaduka Mamaduka merged commit 2185547 into WordPress:trunk Apr 2, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.7 milestone Apr 2, 2025
@shimotmk
Copy link
Contributor Author

shimotmk commented Apr 2, 2025

Thanks for the review!

@shimotmk shimotmk deleted the fix/search-inside-wrapper-classname-trim branch April 2, 2025 10:39
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@shimotmk @Mamaduka @chriszarate
Search: wp-block-search__inside-wrapper classname trailing spaces (W…
df49dbd 
…ordPress#69405)

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 20.7
Development

Successfully merging this pull request may close these issues.
2 participants
@shimotmk @Mamaduka