Skip to content

Archives Block: Fix showLabel default state #69469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Mar 6, 2025

What?

Follow up on #67841 #68757

Why?

The default value of showLabel is true.
In tunk, pressing the reset button will not change anything.

"showLabel": {
"type": "boolean",
"default": true
},

How?

Fixed incorrect initial value of reset button in archive block.

Testing Instructions

  1. Open a post or page.
  2. Insert a Archives block.

Screenshots or screencast

Before

before.mp4

After

after.mp4

Copy link

github-actions bot commented Mar 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shimotmk shimotmk changed the title Archives Block: Fix show label default state Archives Block: Fix showLabel default state Mar 6, 2025
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Archives Affects the Archives Block labels Mar 6, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, @shimotmk!

Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 6, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 6, 2025
@Mamaduka Mamaduka merged commit e1fad76 into WordPress:trunk Mar 6, 2025
69 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 6, 2025
@shimotmk shimotmk deleted the archives/fix-show-label-state branch March 6, 2025 21:08
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Archives Affects the Archives Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants