The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org>
Co-authored-by: code-with-mehedi <mehedi_csit@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +92 B (0%)

Total Size: 1.84 MB

_{compressed-size-action}

Flaky tests detected in 6c79412.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13693959952
📝 Reported issues:

• [Flaky Test] Redirection after template creation #60678 in /test/e2e/specs/site-editor/site-editor-url-navigation.spec.js

Hi @carolinan , If we are not showing the Categories and tags in the panel at all I guess we can also remove the useEffect as its only purpose was to allow user to add new categories and tags from the panel, further more is it possible to use useMemo too op optimise the component further and to avoid re-renders ?

@HILAYTRIVEDI, the useEffect has a comment on why it's needed, and the same logic still applies.

further more is it possible to use useMemo too op optimise the component further and to avoid re-renders ?

I don't think there will be any actual performance gain from this. The components are only rendered during publishing steps.

Yes but @Mamaduka , it will only be visible if we want to let user add the categories and with this solution we are completely removing that from the side panel so this ( useEffect ) will not have any effect even if I remove it.

Also , We can use useMemo for checking if the post Type supports the categories or not. For example :

it will only be visible if we want to let use add the categories and with this solution we are completely removing that from the side panel so this ( useEffect ) will not have any effect even if I remove it.

Nothing is being removed completely; if a site has some categories, the panel will function as before. You can give it a try.

Also , We can use useMemo for checking if the post Type supports the categories or not. For example:

I wouldn't recommend adding memoization to everything. Memoizing that values vs not memoizing won't really change anything.

Related reading:

• https://kentcdodds.com/blog/usememo-and-usecallback
• https://royi-codes.vercel.app/thousand-usecallbacks/

Thank you @Mamaduka for the reads on the performance optimisation techniques.

I noticed this snippet in the repo:

The resetAllFilter function is used in a Wrapper component which is not memoized and would most likely rerender on every state update.

Similarly, the objects returned by useMemo are used in the <DuotonePicker> component:

Since both the Wrapper and DuotonePicker components are not memoized, I believe these hooks might be doing more harm than good. When any state updates, these components would be re-rendered anyway, making the memoization unnecessary and potentially adding overhead.

Let me know what you think about this @Mamaduka

@im3dabasia, I wouldn't start refactoring that component just to remove memoization. They're not broken, and removing or leaving them in won't have any measurable performance impact. It's just something to keep in mind for future work.

P.S. IMO, currently, our resources are better spent on fixing actual bugs.

I believe these hooks might be doing more harm than good. When any state updates, these components would be re-rendered anyway, making the memoization unnecessary and potentially adding overhead.

Unfortunately, there's no single rule when it comes to performance optimizations; it is just best practices and examples that need to be analyzed case by case.