Skip to content

Revert "Feature: Add navigation.isLoading state to core/router store (#67680)" #69330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

fabiankaegy
Copy link
Member

What?

Closes

This reverts commit e85937f. (#67680)

Why?

After chatting with @luisherranz for a bit, this API is not through and future proof enough to release in 6.8

@fabiankaegy fabiankaegy added [Type] Code Quality Issues or PRs that relate to code quality [Package] Interactivity Router /packages/interactivity-router labels Feb 26, 2025
@fabiankaegy fabiankaegy requested a review from Mamaduka February 26, 2025 15:12
@fabiankaegy fabiankaegy self-assigned this Feb 26, 2025
@fabiankaegy fabiankaegy requested a review from t-hamano February 26, 2025 15:12
Copy link

github-actions bot commented Feb 26, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fabiankaegy!

@luisherranz
Copy link
Member

@fabiankaegy do you want to land this instead?

Copy link

Flaky tests detected in 43bef97.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13547107626
📝 Reported issues:

@fabiankaegy fabiankaegy merged commit 5e7c286 into trunk Feb 28, 2025
70 checks passed
@fabiankaegy fabiankaegy deleted the revert/67680 branch February 28, 2025 08:30
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.8 Editor Tasks Feb 28, 2025
@github-actions github-actions bot added this to the Gutenberg 20.4 milestone Feb 28, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
WordPress#67680)" (WordPress#69330)

This reverts commit e85937f.

Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Interactivity Router /packages/interactivity-router [Type] Code Quality Issues or PRs that relate to code quality
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants