Site Editor: Fix space on the left or right of the menu in mobile view #69327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +68 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
vcanales
approved these changes
Feb 27, 2025
Mamaduka
approved these changes
Feb 27, 2025
6 tasks
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
WordPress#69327) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69156
Restores left and right spacing in the mobile layout of the site editor that was lost in the latest Gutenberg.
Why?
This issue does not occur in desktop layouts. I think the root cause is that the hierarchy of elements in mobile layouts is very different from that of desktop.
Desktop:
Mobile:
How?
I understand that the different hierarchy of elements is a result of enabling screen navigation in the mobile layout. For now, I only add left and right spacing to the mobile layout. In the future, once the components that make up the mobile layout are simplified, we may be able to make the sidebar in the mobile layout consistent with that of the desktop layout (See #69172).
Testing Instructions
Screenshots or screencast