Skip to content

Navigation Block: Add transparency slider for submenu background #69379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

Navigation Block: Add transparency slider for submenu background #69379

merged 2 commits into from
Mar 27, 2025

Conversation

dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Mar 3, 2025 •
edited
Loading

Closes: #53487

What?

This PR adds the ability to set a transparent background for Navigation Block submenus by enabling the alpha (transparency) channel in the color picker for the submenu background setting.

Why?

Currently, users who want their submenu background to be transparent (to match the transparent background of the navigation block) have to use custom CSS. When no background color is set, submenus default to a white background, and the existing color picker doesn't allow for transparency settings.

This improvement creates a more intuitive user experience by allowing transparency to be set directly from the editor interface without requiring custom code.

How?

The implementation adds the enableAlpha: true property to the color settings for the submenu & overlay background in the ColorGradientSettingsDropdown component. This enables the transparency slider in the WordPress color picker component, allowing users to select any level of transparency for submenu backgrounds.

Testing Instructions

  1. Create a new page/post and add a Navigation Block
  2. Add a submenu item to the navigation
  3. In the sidebar, under the Color panel, find the "Submenu & overlay background" color setting
    Select a custom color
  4. Verify that a transparency/opacity slider is now available
  5. Adjust the transparency and check that the submenu background shows the correct transparency level

Screenshots or screencast

Before

Before.mov

After

After.mov

@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review March 4, 2025 05:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org>
Co-authored-by: ajitbohra <ajitbohra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: cuemarie <plari@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ajitbohra
ajitbohra approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhruvikpatel18
Copy link
Contributor Author

Hi @ajitbohra
Since the PR has been approved, I believe we can proceed with merging it now. Let me know if anything else is needed. Thanks!

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Mar 25, 2025
@Mamaduka
Copy link
Member

@dhruvikpatel18, do you mind rebasing this branch? That should resolve CI failures.

@dhruvikpatel18 dhruvikpatel18 force-pushed the add/navigation-submenu-transparency branch from 07bb07f to 0fbeedc Compare March 26, 2025 06:52
@Mamaduka Mamaduka self-requested a review March 26, 2025 06:55
@Mamaduka
Copy link
Member

Thanks for the rebase, @dhruvikpatel18!

What do you think about enabling transparency for other color settings as well, just to make it consistent? Seems odd to have it only enabled for once, even if it might get more actual use.

@dhruvikpatel18
Copy link
Contributor Author

@Mamaduka, Thank you for the feedback, I agree that enabling transparency for all color settings would provide a more uniform and flexible user experience.

I'll modify the code to enabling transparency for other color settings in the ColorGradientSettingsDropdown. This will allow users to adjust transparency across all color pickers in the Navigation block, including:

  • Text Color
  • Background Color
  • Submenu & Overlay Text Color
  • Submenu & Overlay Background Color

@Mamaduka
Copy link
Member

Thanks for the follow-up, @dhruvikpatel18!

Rebasing should fix the failing e2e test.

@dhruvikpatel18 dhruvikpatel18 force-pushed the add/navigation-submenu-transparency branch from a90fac1 to 3e447df Compare March 27, 2025 08:48
@Mamaduka Mamaduka merged commit 63c711d into WordPress:trunk Mar 27, 2025
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 27, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@dhruvikpatel18 @Mamaduka @chriszarate
Navigation Block: Add transparency slider for submenu background (Wor…
619a373 
…dPress#69379)

Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org>
Co-authored-by: ajitbohra <ajitbohra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: cuemarie <plari@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra ajitbohra approved these changes

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.6
Development

Successfully merging this pull request may close these issues.

Navigation Block: Allow for transparent submenu background
3 participants
@dhruvikpatel18 @Mamaduka @ajitbohra