Performance Tests: Update method for creating sample content #69210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
Feb 16, 2025
| @@ -74,7 +74,7 @@ export async function createPage( | |||
| const page = await this.rest< Page >( { | |||
| method: 'POST', | |||
| path: `/wp/v2/pages`, | |||
| params: payload, | |||
| data: { ...payload }, | |||
There was a problem hiding this comment.
The createPage sent data via query arguments for the POST request; it should be sent a body.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in ebddc3f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13353104665
|
swissspidy
approved these changes
Feb 16, 2025
|
Thanks, @swissspidy! |
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
…ss#69210) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
|
I noticed a small spike in the Site Editor "first block load" performance metrics. Going to investigate this separately. Screenshot |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ss#69210) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Required for #69173.
PR updates the method for creating page fixtures for the Site Editor's performance tests. Instead of creating large pages "manually," the new method uses a REST API, eliminating the need to switch the editor's rendering mode.
Bonus: Using REST API requests should be a bit faster.
Testing Instructions
All related CI checks should be green.