Editor: Use a stable array ref as fallback value in 'BlockVisibility' #69288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6c4d4d6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13493401907
|
t-hamano
approved these changes
Feb 24, 2025
|
This particular case won’t affect performance, but it’s better to follow best practices everywhere. A lot of people copy and modify code from core. Using empty array or object fallback is common pattern in core. P.S. The 6.8 will also ship with warning in dev mode to catch similar pitfalls. I’ve dev note for it somewhere happy to share if you’re interested. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#69288) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #67052.
PR updates the selector value fallback in the
BlockVisibilitycomponent to use a stable array reference instead of returning a new array on each call.Note: The issue doesn't affect current editors because they preset preference default values.
gutenberg/packages/edit-post/src/index.js
Line 67 in b06588e
Why?
Prevents potential
useSelecthook warnings when thehiddenBlockTypesuser preference isundefined.Testing Instructions
Testing Instructions for Keyboard
Same.