Site Title: Fix logic for 'aria-current' attribute #68909

bschneidewind · 2025-01-28T04:42:10Z

What?

This updates the core/site-title block and the aria-current attribute. This should only be applied to the front page and prevents the aria-current being applied if a user has a separate front page from the posts page. (the posts page should not have an aria-current attribute applied to site title in these instances)

Why?

Resolves bug where a separate posts page has the site-title attribute applied to the site-title (should only be applied to the front page)

How?

Testing Instructions

Under settings->reading select a posts page and a homepage.
Visit the posts page on the front end and inspect the site title, you'll see an aria-current attribute applied.

Trac ticket: https://core.trac.wordpress.org/ticket/62874

…e on the posts page

github-actions · 2025-01-28T04:42:24Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @bjschneidewind@santanderconsumerusa.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: bjschneidewind@santanderconsumerusa.com.

Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org>
Co-authored-by: bschneidewind <bschneidewind@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-01-28T04:42:42Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bschneidewind! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

hbhalodia · 2025-01-28T04:46:52Z

Hi @bschneidewind, Can you please add the core trac ticket here? or create an issue on this repo to reference this PR?

Thank You,

sabernhardt · 2025-01-28T16:54:22Z

The Home Link block has a different conditional statement:

gutenberg/packages/block-library/src/home-link/index.php

Lines 142 to 149 in 6800a97

    
           $aria_current = ''; 
        
           if ( is_front_page() ) { 
        
           	$aria_current = ' aria-current="page"'; 
        
           } elseif ( is_home() && ( (int) get_option( 'page_for_posts' ) !== get_queried_object_id() ) ) { 
        
           	// Edge case where the Reading settings has a posts page set but not a static homepage. 
        
           	$aria_current = ' aria-current="page"'; 
        
           }

And neither block matches the condition in get_custom_logo():
$aria_current = is_front_page() && ! is_paged() ? ' aria-current="page"' : '';

bschneidewind · 2025-01-28T18:10:27Z

Thank you @sabernhardt - helped ID another edge case and reworked this code a bit!

carolinan · 2025-02-28T11:49:08Z

Test results

Your homepage displays Your latest posts

Home:
✅ The site title has aria-current="page".
Paged result of the blog post archive:
✅ The site title does not have aria-current="page".

Your homepage displays A static page

Homepage is selected in the option. Posts page is selected in the option.
Home:
✅ The site title has aria-current="page".
Posts page:
✅ The site title does not have aria-current="page".

Homepage is selected in the option. Posts page is not selected.
Home:
✅ The site title has aria-current="page".

Homepage is not selected in the option. Posts page is selected.
Home:
✅ The site title has aria-current="page".
Paged result of the blog post archive:
✅ The site title does not have aria-current="page".

carolinan · 2025-02-28T11:52:25Z

I am moving this to the 6.8 board because the original trac ticket is on the 6.8 milestone, labeled as an accessibility bug.

Unlinked contributors: bjschneidewind@santanderconsumerusa.com. Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org> Co-authored-by: bschneidewind <bschneidewind@git.wordpress.org>

Mamaduka · 2025-03-05T13:06:10Z

I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 9f8d16d.

Unlinked contributors: bjschneidewind@santanderconsumerusa.com. Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org> Co-authored-by: bschneidewind <bschneidewind@git.wordpress.org>

Remove the aria-current attribute from being applied to the site titl…

6800a97

…e on the posts page

bschneidewind requested review from ajitbohra and fabiankaegy as code owners January 28, 2025 04:42

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 28, 2025

t-hamano added [Type] Bug An existing feature does not function as intended [Block] Site Title Affects the Site Title Block labels Jan 28, 2025

hbhalodia requested a review from joedolson January 28, 2025 06:55

Update index.php

ebc8ba6

Mamaduka changed the title ~~Remove the aria-current attribute from being applied to the site titl…~~ Site Title: Fix logic for aria-current attribute Jan 29, 2025

Mamaduka changed the title ~~Site Title: Fix logic for aria-current attribute~~ Site Title: Fix logic for 'aria-current' attribute Jan 29, 2025

carolinan approved these changes Feb 28, 2025

View reviewed changes

carolinan added this to WordPress 6.8 Editor Tasks Feb 28, 2025

github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.8 Editor Tasks Feb 28, 2025

carolinan added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Feb 28, 2025

joedolson approved these changes Mar 4, 2025

View reviewed changes

Mamaduka added Backport to WP 6.8 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta props-bot Adding this label triggers the Props Bot workflow for a PR. labels Mar 5, 2025

github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 5, 2025

Mamaduka merged commit 5e9bb89 into WordPress:trunk Mar 5, 2025
72 checks passed

github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.8 Editor Tasks Mar 5, 2025

github-actions bot added this to the Gutenberg 20.5 milestone Mar 5, 2025

Mamaduka added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.8 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Mar 5, 2025

Mamaduka mentioned this pull request Mar 10, 2025

Editor: Update packages for 6.8 Beta 2 WordPress/wordpress-develop#8482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Site Title: Fix logic for 'aria-current' attribute #68909

Site Title: Fix logic for 'aria-current' attribute #68909

Uh oh!

bschneidewind commented Jan 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

hbhalodia commented Jan 28, 2025

Uh oh!

sabernhardt commented Jan 28, 2025

Uh oh!

bschneidewind commented Jan 28, 2025

Uh oh!

carolinan commented Feb 28, 2025

Uh oh!

carolinan commented Feb 28, 2025

Uh oh!

Uh oh!

Mamaduka commented Mar 5, 2025

Uh oh!

Uh oh!

Site Title: Fix logic for 'aria-current' attribute #68909

Site Title: Fix logic for 'aria-current' attribute #68909

Uh oh!

Conversation

bschneidewind commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

hbhalodia commented Jan 28, 2025

Uh oh!

sabernhardt commented Jan 28, 2025

Uh oh!

bschneidewind commented Jan 28, 2025

Uh oh!

carolinan commented Feb 28, 2025

Test results

Your homepage displays Your latest posts

Your homepage displays A static page

Uh oh!

carolinan commented Feb 28, 2025

Uh oh!

Uh oh!

Mamaduka commented Mar 5, 2025

Uh oh!

Uh oh!

bschneidewind commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading