Site editor: fix nav error due to lack of context provider in narrow viewports #68907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d6f7eb1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13001678840
|
|
Thanks for the PR! I think this PR is working fine and ready to ship, what do you think? I'm thinking of an alternative approach, wrapping diffdiff --git a/packages/edit-site/src/components/layout/index.js b/packages/edit-site/src/components/layout/index.js
index a5e14f0be8..b31f691ee7 100644
--- a/packages/edit-site/src/components/layout/index.js
+++ b/packages/edit-site/src/components/layout/index.js
@@ -163,7 +163,7 @@ function Layout() {
{ isMobileViewport && areas.mobile && (
<div className="edit-site-layout__mobile">
- { canvas !== 'edit' && (
+ { canvas !== 'edit' ? (
<SidebarContent routeKey={ routeKey }>
<SiteHubMobile
ref={ toggleRef }
@@ -171,9 +171,13 @@ function Layout() {
isResizableFrameOversized
}
/>
+ <ErrorBoundary>
+ { areas.mobile }
+ </ErrorBoundary>
</SidebarContent>
+ ) : (
+ <ErrorBoundary>{ areas.mobile }</ErrorBoundary>
) }
- <ErrorBoundary>{ areas.mobile }</ErrorBoundary>
</div>
) }However, some CSS tweaks might be required, e.g. Pages screen: screenshotWhat do you think about this approach? However, this approach is primarily intended to limit the scope of coverage for the context provider, and I have no strong opinion regarding this approach. |
|
P.S. After this PR is merged, I plan to fix the missing horizontal spacing in the mobile layout. At that time, I may make some adjustments to the DOM structure of the |
6 tasks
|
Thanks for testing this and the alternative suggestion Aki! I don’t have a strong opinion between this or your suggestion. I haven’t tested yours out or thought about how it might impact any further efforts though.
From what I see the value of this context provider is completely stable so I think expanding its scope should make no difference. If you agree, perhaps not having to make any CSS tweaks on this branch makes it more favorable for now. Yet I’m not sure I favor this approach anyway. I have a new alternative #69172 that may be the most advantageous. It removes the need for this context provider and therefore should facilitate doing whatever is best with the markup and style for related concerns/issues like #69156. For now it’s based on #69103 because it relies on a small change in the router that was also needed there. |
|
Closing this because #69413 takes care of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoids a non-fatal error being logged in the console when navigating the site editor in narrow viewports.
The changes here were a quick take on this and there certainly may be a better solution.
Why?
To keep the console logs clean. Resolves #68929
How?
Moves the context provider that’s missing in the narrow viewport out/up in the tree so it’s a available for the mobile route area.
Testing Instructions