Skip to content

Conversation

shimotmk
Copy link
Contributor

What?

Include trimming in Navigation Submenu to make it more consistent with other blocks

Similar #68161

Why?

How?

Testing Instructions

  1. Open a post or page.
  2. Insert a Navigation block and Navigation submenu block.
  3. The space before the class of wp-block-navigation-item is disappearing.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before after

Copy link

github-actions bot commented Jan 25, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Code Quality Issues or PRs that relate to code quality labels Jan 25, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and refactoring looks good ✅

Thanks, @shimotmk!

@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 27, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 27, 2025
@Mamaduka Mamaduka merged commit 55de826 into WordPress:trunk Jan 27, 2025
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 27, 2025
@shimotmk
Copy link
Contributor Author

Thank you😌

@shimotmk shimotmk deleted the fix/navigation-submenu-classname-trim branch January 27, 2025 21:16
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants