Skip to content

Pullquote: Adding missing alignment style #68121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benazeer-ben
Copy link
Contributor

What?

Fixes: #53879

Why?

The styles for the pullquote block do not explicitly define what happens with .has-text-align-center.

How?

Added style for has-text-align-center class in style.css

Testing Instructions

  • Override default style for textAlign of the pullquote with CSS or theme.json.
  • Select the "Center" text align option

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <benazeer@git.wordpress.org>
Co-authored-by: mrwweb <mrwweb@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Pullquote Affects the Pullquote Block labels Jan 6, 2025
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this by adding the following CSS to Twenty Ten:

blockquote {
	text-align: left;
}

When I select the "Align text to center" option, the text is now centered correctly.

@carolinan carolinan merged commit 5c38661 into WordPress:trunk Feb 27, 2025
68 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.4 milestone Feb 27, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: benazeer-ben <benazeer@git.wordpress.org>
Co-authored-by: mrwweb <mrwweb@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles missing for pullquote with text-align-center
3 participants