Feature: Keep track of loading state of query loop block #67820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +26 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
luisherranz
requested changes
Dec 19, 2024
luisherranz
reviewed
Feb 20, 2025
luisherranz
approved these changes
Feb 27, 2025
49 tasks
Great addition :) Co-authored-by: Luis Herranz <luisherranz@gmail.com>
|
It's seems like we need to update this test: test_rendering_query_with_enhanced_pagination By the way, we could reduce the surface area of that test and only check that the main directives, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Keep track of the
loadingstate of the Query Loop router region.Why?
This was discussed a bit in slack: https://wordpress.slack.com/archives/C071CRKGKUP/p1733744467794479
It allows us to do more in terms of loading indicators when any interactive blocks nested inside the query trigger a navigation.
How?
The query loop already proxies the
actions.navigaitefunction from thecore/routerstore trough it's own customnavigateaction. So we can use that to manually keep track of the loading state for the query that can be accessed by any child blocks nested within the query.Testing Instructions
is-current-navigation-originclass gets added to the query loop block when new results are fetched.