-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Display Checkbox by default in dataviews #67874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Checkbox by default in dataviews #67874
Conversation
This reverts commit 63f81c1.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@afercia - Please check this PR when you get some time. Thanks in advance. |
From my understanding, we have not reached a consensus on #59175, so we need to be cautious about moving forward with PRs with visual changes like this one. In the past, certain changes have been reverted or suggested to be reverted as not being ideal. For example:
I don't want to cause something similar as much as possible. Let's discuss it a bit more on #59175 until we reach a solid consensus. |
@karthick-murugan I think we need to use media queries based on hover support rather than viewport. Also, I think what's expected here is to always show checkboxes in the Grid layout, not the Table layout. |
@t-hamano updated the changes. Please have a look. |
@t-hamano - Please let me know if any other changes required. |
@karthick-murugan I think we can use the existing selector: .dataviews-view-grid__card .dataviews-selection-checkbox {
position: absolute;
top: -9999em;
left: $grid-unit-10;
z-index: z-index(".dataviews-view-grid__card .dataviews-selection-checkbox");
@media (hover: none) {
// Show checkboxes on devices that do not support hover.
top: $grid-unit-10;
}
}
|
@t-hamano - Changes updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Finally, can you rebase this PR by using trunk branch? This should resolve CI failures.
…d/checkbox-by-default
Rebased the PR @t-hamano |
* Image size fix in lightbox * Revert "Image size fix in lightbox" This reverts commit 63f81c1. * Add checkbox to site-editor pages by default * Feedback Changes updated * Updating grid layout * Feedback changes Co-authored-by: karthick-murugan <karthickmurugan@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org> Co-authored-by: TimothyBJacobs <timothyblynjacobs@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
What?
Fixes #59175
This PR makes checkboxes in table and grid layouts always visible by removing hidden states and unnecessary hover/focus styles.
Why?
The changes improve:
How?
Testing Instructions
Screenshots or screencast
REC-20241212161332.mp4