Skip to content

Conversation

snehapatil2001
Copy link
Contributor

@snehapatil2001 snehapatil2001 commented Dec 9, 2024

closes #67697

What?

This PR updates template-related messages in the Gutenberg editor to use generic phrasing, removing references to specific post types like "posts" and "pages."

Why?

Template messages previously referred to "posts" and "pages," which could be confusing when working with custom post types or templates shared across different post types (e.g., products, orders). This change ensures the messages are more inclusive and clear for all scenarios.

How?

  • Updated the dialog text when selecting a template block in template-lock mode to avoid post-type-specific references.
  • Revised the Save Changes sidebar description to use generic phrasing, referring to "other parts of your site" instead.

Testing Instructions

  1. Open the Gutenberg editor.
  2. Select a template block that is part of a locked template.
  3. Verify the updated dialog message appears.
  4. Make a change to a template and open the Save Changes sidebar.
  5. Verify the updated Save Changes sidebar message appears.

Copy link

github-actions bot commented Dec 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: snehapatil2001 <snehapatil02@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad
Copy link
Contributor

Would love a confirmation for the copy here. But it's a good change IMO

@youknowriad youknowriad requested a review from mcsf December 24, 2024 13:42
@youknowriad youknowriad added the [Type] Copy Issues or PRs that need copy editing assistance label Dec 24, 2024
@Mamaduka Mamaduka added the [Package] Editor /packages/editor label Feb 17, 2025
@Mamaduka Mamaduka merged commit 6b60dba into WordPress:trunk Feb 17, 2025
67 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.4 milestone Feb 17, 2025
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
…ypes (WordPress#67722)


Co-authored-by: snehapatil2001 <snehapatil02@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ypes (WordPress#67722)


Co-authored-by: snehapatil2001 <snehapatil02@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update texts related to templates to be suitable for custom post types
3 participants