Skip to content

Conversation

manzoorwanijk
Copy link
Member

What?

Convert the notices package to TypeScript

Why?

To improve the DX

How?

By renaming the files and adding types

Testing Instructions

  • CI should be happy

Testing Instructions for Keyboard

Screenshots or screencast

Before After

Copy link

github-actions bot commented Dec 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo gziolo added [Package] Notices /packages/notices [Type] Code Quality Issues or PRs that relate to code quality Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Dec 4, 2024
@manzoorwanijk manzoorwanijk closed this by deleting the head repository Dec 6, 2024
@gziolo
Copy link
Member

gziolo commented Dec 6, 2024

Moved to #67667.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Package] Notices /packages/notices [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants