The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: relic-se <ogrecooper@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Thanks for getting on top of this, @Infinite-Null ! My only suggestion is that I feel the ToggleControl should be placed underneath "Link" rather than at the top of the Navigation Link block settings.

Thanks for getting on top of this, @Infinite-Null ! My only suggestion is that I feel the ToggleControl should be placed underneath "Link" rather than at the top of the Navigation Link block settings.

Hi @relic-se,

Thank you for the valuable suggestion! is this correct?

Yes, that looks great. I think you've provided a quick, simple solution for this problem. All clear with me!

Should it be a simple checkbox to match what's inside the link dialog?

It doesn't seem valuable to have two different designs for this. Thanks for the PR!

Hi @jasmussen,
Thanks for the feedback 🙌! I’ve updated the PR to use a simple checkbox to match what’s inside the link dialog, ensuring consistency in design. Please review it at your convenience.

Screenshot:

Nice quick action. I'd omit the help text, though, the checkbox itself seems plenty descriptive, and by removing the help text you further ensure it's the same design.

Thanks for the feedback @jasmussen,
I have updated the PR and removed the help text:

Nice, works for me. I'll defer to others on the details. 👍 👍

We should probably apply the same to the Submenu block