-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Spacer: Add border support #66443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacer: Add border support #66443
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing this PR @karthick-murugan 👍
I'm not sure adding visual styles to the Spacer block is the direction we want to go. My understanding is this block is meant purely for layout and spacing purposes.
The same concern is raised over on the PR proposing to add color support to the Spacer block (#66433).
I've added the Needs Design Feedback
label in order to get a design perspective on this.
I would love to see this featured merged, as stated in #43247 (comment) already. My current situation: Building a timeline / step-by-step guide with a dotted border in between the groups. |
This change will end up confusing more users than it helps. Just because one person has a specific need doesn’t mean it makes sense to implement it in core. WordPress features have to be broadly useful, not just accommodate edge cases for a single user. If we added a setting for every small feature request, we’d end up with tens of thousands of options, making WordPress unusable. If you need this behavior, the best approach is to use custom CSS. That way, you get exactly what you need without adding unnecessary complexity for everyone else. |
Why do you think so? I also added some arguments about the background for the spacer block to the other discussion but they apply also for the border. Having many groups and divs that do not represent the correct size on the front end is rather confusing and contradicts the idea of a full site WYSIWYG editor.
I agree with sentiment in general and there is a lively discussion ongoing in the WordPress community, like https://kraut.press/2024/wordpress-isnt-wordpress-anymore/
Here I disagree with you. The block editor has currently a bad user experience because often it's missing options where users would expect them to be. Also, this would rather be a design issue that could be solved (and is for example already partly with the block locking api). If you logic
Again, I don't see any complexity in adding existing appearance tools to the existing (and currently for the spacing block nearly empty) Inspector. |
@t-hamano - Can I close this PR based on the comments of this PR #66433 (comment) ? |
Yeah, let's close it for now. All the same issues in #66433 apply here too. |
What?
Add border block support to the Spacer block.
Part of #43247
Why?
Spacer
block is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
In Backend:

In Frontend:
