-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add: Multiple media field support and content field to pages/posts. #65331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Multiple media field support and content field to pages/posts. #65331
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +442 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
#65107 is very relevant to the conversation here as it could significantly increase the likelihood of pages having a featured image. That coupled with the poor performance of loading full page previews leads me to think we shouldn't change the default preview as a part of this PR. That feels like a detail to discuss separately.
This interaction doesn't feel great right now because toggling the featured image field has a totally different outcome to toggling any other field. It doesn't feel like you're choosing between one option or another. The way I'm looking at this is; there are two properties associated with the Preview field, and the user can choose between them. The UI should reflect this. How do you feel about something like this mockup: |
41dab5c
to
30ea014
Compare
30ea014
to
04041a2
Compare
04041a2
to
0308522
Compare
Meanwhile, the codebase changed a lot, I proposed a new version of this PR taking into account its feedback at #67278. |
Fixes #63719.
cc: @jameskoster, @jasmussen
This PR implements the following changes:
Most pages don't have a featured image so this PR fixes the issue of having a gray square as a page media as the UI shown most of the time.
Testing Instructions
Screenshots or screen