Skip to content

Conversation

shail-mehta
Copy link
Member

What?

Add border block support to the Comment Template block.

Part of #43247

Why?

Comment Template block is missing border support.

How?

Adds the border block support in block.json.

Testing Instructions

  • Go to Global Styles Settings ( Under Appearance > Editor > Styles > Edit styles > Blocks ).
  • Make sure that Comment Template block's border is Configurable via Global Styles.
  • Edit Template/Page & Add Comment Template block and Apply the border Styles.
  • Verify that Comment Template block styles take precedence over global Styles.
  • Verify that Comment Template block borders display correctly in both the Editor and Frontend.

Screenshots or Screencast

add-border-support-in-comment-template.mp4

@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Comment Template Affects the Comment Template Block labels Aug 4, 2024
@shail-mehta shail-mehta self-assigned this Aug 4, 2024
Copy link

github-actions bot commented Aug 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Border styles are output by global styles :root :where(.wp-block-comment-template), and overridden by block-level inline CSS.

Screenshot 2024-08-07 at 11 54 02 AM

@ramonjd ramonjd merged commit 8c0bcdd into trunk Aug 7, 2024
70 checks passed
@ramonjd ramonjd deleted the add/comment-template-border-support branch August 7, 2024 02:02
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 7, 2024
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Template Affects the Comment Template Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants