Post Comments Form: Add Border Block Support #64233
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
LGTM!
- ✅Global styles are applied correctly.
- ✅Styles are consistent between the editor and the front end.
- ✅Can override styles from block instances.
- ✅
box-sizingis already applied.
One thing I noticed is that the corners of the border are sometimes hidden by the placeholder when it's visible, i.e. when comments are disabled. However, this also happens with other blocks, so I don't think it's necessarily a bug that needs to be fixed, and I think it can be addressed in a follow-up if necessary.
What?
Add border block support to the
Post Comment Formblock.Part of #43247
Why?
Post Comment Formblock is missing border support.How?
Adds the border block support in block.json.
Testing Instructions
Post Comment Formblock's border is Configurable via Global Styles.Post Comment Formblock and Apply the border Styles.Post Comment Formblock styles take precedence over global Styles.Post Comment Formblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-post-comment-forms.mp4