Skip to content

Update pagination design with mininal variant for select control #63691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Update pagination design with mininal variant for select control #63691

wants to merge 1 commit into from

Conversation

dhananjaykuber
Copy link
Contributor

Fixes #63675

What?

Update the pagination UI design in data views using the new minimal variant of SelectControl.

Why?

This PR aims to streamline and modernize the pagination UI in data views by leveraging the recently introduced minimal variant of SelectControl (#63265). This change will improve visual consistency and provide a cleaner, more minimal interface for users navigating through paginated content.

How?

The implementation involves adding the variant="minimal" prop to the SelectControl component used in the pagination UI.

Screenshots or screencast

Screenshot 2024-07-18 at 12 38 56 PM

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dhananjaykuber dhananjaykuber changed the title update pagination design with mininal variant for select control Update pagination design with mininal variant for select control Jul 18, 2024
@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jul 18, 2024
@t-hamano t-hamano mentioned this pull request Jul 23, 2024
Merged
@jameskoster
Copy link
Contributor

Thanks for the PR.

This change gets us part of the way there, but ideally the full text should be the label, like the mockup in #63675.

One challenge is that applying text-transform: uppercase to the select also affects the options, which is undesirable. I wonder if there's a way around that, or whether we should use regular text styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pagination design
3 participants
@dhananjaykuber @jameskoster @akasunil