Skip to content

Conversation

MaggieCabrera
Copy link
Contributor

What?

Add a basic example to the core/post-date block.

Part of #30029

Why?

Because it was showing empty before

How?

I define a viewport size for the example

Testing Instructions

Open the block inserter and search for the post date block, hover over it and you'll see the example.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-07-10 at 18 02 48

@MaggieCabrera MaggieCabrera added [Type] Enhancement A suggestion for improvement. [Block] Post Date Affects the Post Date Block labels Jul 10, 2024
@MaggieCabrera MaggieCabrera self-assigned this Jul 10, 2024
@MaggieCabrera MaggieCabrera requested a review from ajitbohra as a code owner July 10, 2024 16:05
Copy link

github-actions bot commented Jul 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the site editor, I just see this:

Screenshot 2024-07-11 at 09 41 06

That's better than no preview, but if we can provide custom dates here, that would be better.

@jasmussen
Copy link
Contributor

If you can provide custom content, an easter egg such as WordPress' birth date, might be fun.

@MaggieCabrera
Copy link
Contributor Author

If you can provide custom content, an easter egg such as WordPress' birth date, might be fun.

from what I understand, there's no conditional here, if we did set up placeholders (I'm not sure we can) they would replace the real data when there is context

@MaggieCabrera MaggieCabrera merged commit 161c996 into trunk Jul 11, 2024
@MaggieCabrera MaggieCabrera deleted the add-post-date-preview branch July 11, 2024 15:34
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 11, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Date Affects the Post Date Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants