Skip to content

Conversation

mirka
Copy link
Member

@mirka mirka commented Jul 8, 2024

What?

Fixes the text alignment in Tabs when the tab names wrap and orientation="vertical".

Why?

The tab names look misaligned if centered in vertical mode.

Testing Instructions

See Storybook for Tabs.

Screenshots or screencast

Before After
Text aligned to center Text aligned to start

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 8, 2024
@mirka mirka self-assigned this Jul 8, 2024
@mirka mirka requested a review from ajitbohra as a code owner July 8, 2024 20:06
Copy link

github-actions bot commented Jul 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team July 8, 2024 20:07
Copy link
Member

@DaniGuardiola DaniGuardiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mirka mirka merged commit 749bb12 into trunk Jul 9, 2024
@mirka mirka deleted the fix/tabs-vertical-align branch July 9, 2024 11:27
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 9, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Jul 10, 2024
* Tabs: Fix text-align when text wraps in vertical mode

* Add changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
* Tabs: Fix text-align when text wraps in vertical mode

* Add changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants