Skip to content

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Jul 1, 2024

What?

Add n example to the core/post-excerpt block.

Part of #30029

Why?

Because it was showing empty before

How?

By defining a viewport width size for the example

Testing Instructions

Testing Instructions for Keyboard

Create a post and add some content to it.
Open the block inserter and search for the excerpt block, hover over it and you'll see the example

Screenshots or screencast

Screenshot 2024-07-01 at 12 05 02

@MaggieCabrera MaggieCabrera requested a review from ajitbohra as a code owner July 1, 2024 10:06
Copy link

github-actions bot commented Jul 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@MaggieCabrera MaggieCabrera added [Type] Enhancement A suggestion for improvement. [Block] Post Excerpt Affects the Post Excerpt Block labels Jul 1, 2024
@MaggieCabrera MaggieCabrera self-assigned this Jul 1, 2024
Copy link
Contributor

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me.

@MaggieCabrera MaggieCabrera merged commit 54e9849 into trunk Jul 1, 2024
@MaggieCabrera MaggieCabrera deleted the add-excerpt-preview branch July 1, 2024 11:17
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 1, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants