Interactivity: Fix withScope to restore scope on thrown exception inside async functions
#62555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
8 tasks
|
Closing, as this is included as part of this other pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes
withScope()to maintain the Interactivity scope on captured exceptions inside async functions.Related to #59708
Why?
This was previously fixed inside the store proxy handlers but not inside
withScope(), which contains the same logic.How?
Done so by 1) fixing the code inside
withScope(), then 2) removing the duplicated code, and 3) usingwithScope()inside the store proxy handlers.Testing Instructions
Tested by e2e tests (inside
test/e2e/specs/interactivity/async-actions.spec.ts).