Update instances of text-wrap: pretty to fall back to balance #62233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I have a feeling the tests will fail on this one, I didn't have time to do thorough testing, and I have to move on to another task now. Feel free to push directly to this branch if you like. |
fabiankaegy
approved these changes
Jun 3, 2024
|
Size Change: +26 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The performance tests keep failing here. @youknowriad any idea? This is ideally something to backport. |
|
The performance tests are failing almost in all PRs, folks are still investigating these and I'm not sure what's causing the issues. |
|
It should be fine to force merge this. |
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Update instances of text-wrap: pretty to fall back to balance * fix update snapshots * add changelog entry --------- Co-authored-by: Fabian Kägy <mail@fabian-kaegy.de>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Update instances of text-wrap: pretty to fall back to balance * fix update snapshots * add changelog entry --------- Co-authored-by: Fabian Kägy <mail@fabian-kaegy.de>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ess#62233) * Update instances of text-wrap: pretty to fall back to balance * fix update snapshots * add changelog entry --------- Co-authored-by: Fabian Kägy <mail@fabian-kaegy.de>
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hopefully fixes #62215.
Safari doesn't support
text-wrap: pretty;. This PR addsbalanceas a fallback.How?
Test the document inspector in Blink and Safari/Webkit, the metadata should wrap correctly: