Skip to content

Change media-text block placeholder buttons size #61814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Change media-text block placeholder buttons size #61814

wants to merge 2 commits into from

Conversation

prasadkarmalkar
Copy link
Contributor

@prasadkarmalkar prasadkarmalkar commented May 21, 2024 •
edited
Loading

What?

Fixed: #61812

Why?

When you place a media & text block, before selecting a media, there is a placeholder with three buttons.
With Gutenberg active, there is an unexpected change in the styling of the buttons, which are wider than in other placeholders.

How?

In the CSS of media text block I added width for the button as auto when screen size greater than 600px

Testing Instructions

  1. Open post
  2. Insert Media Text block
  3. Check the placeholder buttons size

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-05-21 at 3 01 15 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @philjo107.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: philjo107.

Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 21, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @prasadkarmalkar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano
Copy link
Contributor

@prasadkarmalkar Thanks for the PR!

I believe the current behavior is intentional. See this comment for more details.

@akasunil akasunil added [Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended labels Jun 14, 2024
@Mamaduka
Copy link
Member

Mamaduka commented Aug 5, 2025

Closing based on feedback.

@Mamaduka Mamaduka closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Media & Text Affects the Media & Text Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media & text block: Placeholder buttons has the wrong size
4 participants
@prasadkarmalkar @t-hamano @Mamaduka @akasunil