Skip to content

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Apr 4, 2024

What?

See #60349 (comment). We should skip unknown patterns.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Apr 4, 2024
@ellatrix ellatrix requested a review from spacedmonkey as a code owner April 4, 2024 12:47
Copy link

github-actions bot commented Apr 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ellatrix ellatrix merged commit 2ff5f64 into trunk Apr 4, 2024
@ellatrix ellatrix deleted the try/resolve-patterns-guard branch April 4, 2024 18:23
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 4, 2024
@andrewserong
Copy link
Contributor

Thanks for the quick fix!

cbravobernal pushed a commit to garridinsi/gutenberg that referenced this pull request Apr 9, 2024
…s#60464)

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
@Mamaduka Mamaduka added the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Apr 10, 2024
@Mamaduka Mamaduka removed the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants