Skip to content

Hide save panel button isntead of removing when save panel is open #59716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Hide save panel button isntead of removing when save panel is open #59716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/edit-site/src/components/editor/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@
padding: $grid-unit-30;
display: flex;
justify-content: center;

.is-entity-save-view-open & {
position: absolute;
right: -9999999em;
height: 0;
}
}

// Adjust the position of the notices
Expand Down
30 changes: 14 additions & 16 deletions packages/edit-site/src/components/save-panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,22 +142,20 @@ export default function SavePanel() {
} ) }
ariaLabel={ __( 'Save panel' ) }
>
{ isSaveViewOpen ? (
<_EntitiesSavedStates onClose={ onClose } />
) : (
<div className="edit-site-editor__toggle-save-panel">
<Button
variant="secondary"
className="edit-site-editor__toggle-save-panel-button"
onClick={ () => setIsSaveViewOpened( true ) }
aria-expanded={ false }
disabled={ disabled }
__experimentalIsFocusable
>
{ __( 'Open save panel' ) }
</Button>
</div>
) }
<div className="edit-site-editor__toggle-save-panel">
<Button
variant="secondary"
className="edit-site-editor__toggle-save-panel-button"
onClick={ () => setIsSaveViewOpened( true ) }
aria-expanded={ false }
disabled={ disabled }
aria-haspopup={ 'dialog' }
__experimentalIsFocusable
>
{ __( 'Open save panel' ) }
</Button>
</div>
{ isSaveViewOpen && <_EntitiesSavedStates onClose={ onClose } /> }
</NavigableRegion>
);
}