Date: merge 6.4 and 6.5 compat files #58479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_wp_date_settings(), and stores them in a single place in compat/6.5.
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/script-loader.php ❔ lib/compat/wordpress-6.5/script-loader.php |
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58431
What and how?
This commit merges the 6.4 and 6.5 compat changes for
gutenberg_update_wp_date_settings(), and stores them in a single place in compat/6.5.6.4 compat changes (already merged to Core for 6.4)
6.5 compat changes (needs backporting for 6.5)
Why?
Compat code consolidation and to avoid duplicate filters.
Testing Instructions
Fire up this branch and open the editor.
In the browser console, run
wp.date.getSettings().Check that properties exist for:
timezone.offsetFormattedexistsl10n.relative.*existsSmoke test functionality.
wp.date.humanTimeDiff( new Date() )in the console. You should see a relative translation"a second ago"