Update Pages preview field display #57919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +64 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Jan 17, 2024
| width: $grid-unit-50; | ||
| height: $grid-unit-50; | ||
| display: block; | ||
| .dataviews-view-table { |
There was a problem hiding this comment.
What do we need this for? I presume so these styles are only used in the table layout? Can we perhaps add the .edit-site-page-pages_media-wrapper class (or a different one) to the span in the page-pages/index.js component only if the table layout is in use?
I think it's best if the consumers (Pages, Templates, etc.) don't use dataviews' classes, because they can change. In general, we avoid making classes "public API".
There was a problem hiding this comment.
You mean the specificity? Yes it's because the styles should only be applied in table layout. List layout already adds these styles on behalf of the consumer.
Can we perhaps add the .edit-site-page-pages_media-wrapper class (or a different one) to the span in the page-pages/index.js component only if the table layout is in use?
Let me see if I can do that.
There was a problem hiding this comment.
I can take a look at this and push to the branch tomorrow morning as well.
There was a problem hiding this comment.
I got it working, but there's no doubt a better way so feel free to push any improvements.
oandregal
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57649.
What?
Ensures the preview/media field display for pages is consistent across layouts.
Why?
Currently they are inconsistent:
This PR fixes that inconsistency:
How?
The pages preview/media field output now includes a wrapper to which the required styles are attached.
Note
The styles to achieve the consistent display are applied differently;
I don't know this this is ideal, it might be better to apply the table layout media styles globally, but I believe that's a larger change.