Data: fix memoized createRegistrySelector #57888

ellatrix · 2024-01-16T15:50:53Z

What?

This PR fixes createRegistrySelector when used in combination with a memoized selector (createSelector).

Thanks @jsnajdr for providing some tests in #57510.

The following is currently broken in trunk, it doesn't cache the result:

createRegistrySelector( ( select ) =>
	createSelector(
		( state ) => {
			return select()...
		},
		() => [
			select()...
		]
	)
);

It does not fix binding to registry selectors to multiple registries, but this is already broken in trunk, even without createSelector.

Why?

We have some selectors where memoization is needed. I would also like to add more registry selectors, but this flaw makes it impossible because it would mean adding unperformant selectors in important places.

gutenberg/packages/block-directory/src/store/selectors.js

Lines 56 to 65 in cdd6cec

    
           export const getNewBlockTypes = createRegistrySelector( 
        
           	( select ) => ( state ) => { 
        
           		const usedBlockTree = select( blockEditorStore ).getBlocks(); 
        
           		const installedBlockTypes = getInstalledBlockTypes( state ); 
        
           		return installedBlockTypes.filter( ( blockType ) => 
        
           			hasBlockType( blockType, usedBlockTree ) 
        
           		); 
        
           	} 
        
           );

gutenberg/packages/block-directory/src/store/selectors.js

Lines 75 to 84 in cdd6cec

    
           export const getUnusedBlockTypes = createRegistrySelector( 
        
           	( select ) => ( state ) => { 
        
           		const usedBlockTree = select( blockEditorStore ).getBlocks(); 
        
           		const installedBlockTypes = getInstalledBlockTypes( state ); 
        
           		return installedBlockTypes.filter( 
        
           			( blockType ) => ! hasBlockType( blockType, usedBlockTree ) 
        
           		); 
        
           	} 
        
           );

gutenberg/packages/edit-site/src/store/selectors.js

Lines 244 to 261 in cdd6cec

    
           export const getCurrentTemplateTemplateParts = createRegistrySelector( 
        
           	( select ) => () => { 
        
           		const templateParts = select( coreDataStore ).getEntityRecords( 
        
           			'postType', 
        
           			TEMPLATE_PART_POST_TYPE, 
        
           			{ per_page: -1 } 
        
           		); 
        
           		const clientIds = 
        
           			select( blockEditorStore ).__experimentalGetGlobalBlocksByName( 
        
           				'core/template-part' 
        
           			); 
        
           		const blocks = 
        
           			select( blockEditorStore ).getBlocksByClientId( clientIds ); 
        
           		return getFilteredTemplatePartBlocks( blocks, templateParts ); 
        
           	} 
        
           );

gutenberg/packages/editor/src/store/private-selectors.js

Lines 25 to 47 in cdd6cec

    
           export const getInsertionPoint = createRegistrySelector( 
        
           	( select ) => ( state ) => { 
        
           		if ( typeof state.blockInserterPanel === 'object' ) { 
        
           			return state.blockInserterPanel; 
        
           		} 
        
           		if ( getRenderingMode( state ) === 'template-locked' ) { 
        
           			const [ postContentClientId ] = 
        
           				select( blockEditorStore ).__experimentalGetGlobalBlocksByName( 
        
           					'core/post-content' 
        
           				); 
        
           			if ( postContentClientId ) { 
        
           				return { 
        
           					rootClientId: postContentClientId, 
        
           					insertionIndex: undefined, 
        
           					filterValue: undefined, 
        
           				}; 
        
           			} 
        
           		} 
        
           		return EMPTY_INSERTION_POINT; 
        
           	} 
        
           );

gutenberg/packages/edit-widgets/src/store/selectors.js

Lines 32 to 49 in cdd6cec

    
           export const getWidgets = createRegistrySelector( ( select ) => () => { 
        
           	const widgets = select( coreStore ).getEntityRecords( 
        
           		'root', 
        
           		'widget', 
        
           		buildWidgetsQuery() 
        
           	); 
        
           	return ( 
        
           		// Key widgets by their ID. 
        
           		widgets?.reduce( 
        
           			( allWidgets, widget ) => ( { 
        
           				...allWidgets, 
        
           				[ widget.id ]: widget, 
        
           			} ), 
        
           			{} 
        
           		) || {} 
        
           	); 
        
           } );

And there's places where createRegisterySelector should be used, but currently isn't:

gutenberg/packages/edit-site/src/components/page-patterns/use-patterns.js

Lines 212 to 270 in 588fc12

    
           const selectUserPatterns = createSelector( 
        
           	( select, syncStatus, search = '' ) => { 
        
           		const { getEntityRecords, getIsResolving, getUserPatternCategories } = 
        
           			select( coreStore ); 
        
           		const query = { per_page: -1 }; 
        
           		const records = getEntityRecords( 
        
           			'postType', 
        
           			PATTERN_TYPES.user, 
        
           			query 
        
           		); 
        
           		const userPatternCategories = getUserPatternCategories(); 
        
           		const categories = new Map(); 
        
           		userPatternCategories.forEach( ( userCategory ) => 
        
           			categories.set( userCategory.id, userCategory ) 
        
           		); 
        
           		let patterns = records 
        
           			? records.map( ( record ) => 
        
           					patternBlockToPattern( record, categories ) 
        
           			  ) 
        
           			: EMPTY_PATTERN_LIST; 
        
           		const isResolving = getIsResolving( 'getEntityRecords', [ 
        
           			'postType', 
        
           			PATTERN_TYPES.user, 
        
           			query, 
        
           		] ); 
        
           		if ( syncStatus ) { 
        
           			patterns = patterns.filter( 
        
           				( pattern ) => pattern.syncStatus === syncStatus 
        
           			); 
        
           		} 
        
           		patterns = searchItems( patterns, search, { 
        
           			// We exit user pattern retrieval early if we aren't in the 
        
           			// catch-all category for user created patterns, so it has 
        
           			// to be in the category. 
        
           			hasCategory: () => true, 
        
           		} ); 
        
           		return { 
        
           			patterns, 
        
           			isResolving, 
        
           			categories: userPatternCategories, 
        
           		}; 
        
           	}, 
        
           	( select ) => [ 
        
           		select( coreStore ).getEntityRecords( 'postType', PATTERN_TYPES.user, { 
        
           			per_page: -1, 
        
           		} ), 
        
           		select( coreStore ).getIsResolving( 'getEntityRecords', [ 
        
           			'postType', 
        
           			PATTERN_TYPES.user, 
        
           			{ per_page: -1 }, 
        
           		] ), 
        
           		select( coreStore ).getUserPatternCategories(), 
        
           	] 
        
           );

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

github-actions · 2024-01-16T16:00:14Z

Size Change: +45 B (0%)

Total Size: 1.69 MB

Filename	Size	Change
`build/data/index.min.js`	8.96 kB	+23 B (0%)
`build/interactivity/index.min.js`	12.6 kB	+22 B (0%)

ℹ️ View Unchanged

Filename	Size
`build/a11y/index.min.js`	964 B
`build/annotations/index.min.js`	2.71 kB
`build/api-fetch/index.min.js`	2.33 kB
`build/autop/index.min.js`	2.11 kB
`build/blob/index.min.js`	590 B
`build/block-directory/index.min.js`	7.25 kB
`build/block-directory/style-rtl.css`	1.04 kB
`build/block-directory/style.css`	1.04 kB
`build/block-editor/content-rtl.css`	4.31 kB
`build/block-editor/content.css`	4.31 kB
`build/block-editor/default-editor-styles-rtl.css`	403 B
`build/block-editor/default-editor-styles.css`	403 B
`build/block-editor/index.min.js`	247 kB
`build/block-editor/style-rtl.css`	15.3 kB
`build/block-editor/style.css`	15.3 kB
`build/block-library/blocks/archives/editor-rtl.css`	61 B
`build/block-library/blocks/archives/editor.css`	60 B
`build/block-library/blocks/archives/style-rtl.css`	90 B
`build/block-library/blocks/archives/style.css`	90 B
`build/block-library/blocks/audio/editor-rtl.css`	150 B
`build/block-library/blocks/audio/editor.css`	150 B
`build/block-library/blocks/audio/style-rtl.css`	122 B
`build/block-library/blocks/audio/style.css`	122 B
`build/block-library/blocks/audio/theme-rtl.css`	138 B
`build/block-library/blocks/audio/theme.css`	138 B
`build/block-library/blocks/avatar/editor-rtl.css`	116 B
`build/block-library/blocks/avatar/editor.css`	116 B
`build/block-library/blocks/avatar/style-rtl.css`	104 B
`build/block-library/blocks/avatar/style.css`	104 B
`build/block-library/blocks/block/editor-rtl.css`	305 B
`build/block-library/blocks/block/editor.css`	305 B
`build/block-library/blocks/button/editor-rtl.css`	419 B
`build/block-library/blocks/button/editor.css`	417 B
`build/block-library/blocks/button/style-rtl.css`	632 B
`build/block-library/blocks/button/style.css`	631 B
`build/block-library/blocks/buttons/editor-rtl.css`	337 B
`build/block-library/blocks/buttons/editor.css`	337 B
`build/block-library/blocks/buttons/style-rtl.css`	332 B
`build/block-library/blocks/buttons/style.css`	332 B
`build/block-library/blocks/calendar/style-rtl.css`	239 B
`build/block-library/blocks/calendar/style.css`	239 B
`build/block-library/blocks/categories/editor-rtl.css`	113 B
`build/block-library/blocks/categories/editor.css`	112 B
`build/block-library/blocks/categories/style-rtl.css`	124 B
`build/block-library/blocks/categories/style.css`	124 B
`build/block-library/blocks/code/editor-rtl.css`	53 B
`build/block-library/blocks/code/editor.css`	53 B
`build/block-library/blocks/code/style-rtl.css`	121 B
`build/block-library/blocks/code/style.css`	121 B
`build/block-library/blocks/code/theme-rtl.css`	124 B
`build/block-library/blocks/code/theme.css`	124 B
`build/block-library/blocks/columns/editor-rtl.css`	108 B
`build/block-library/blocks/columns/editor.css`	108 B
`build/block-library/blocks/columns/style-rtl.css`	421 B
`build/block-library/blocks/columns/style.css`	421 B
`build/block-library/blocks/comment-author-avatar/editor-rtl.css`	125 B
`build/block-library/blocks/comment-author-avatar/editor.css`	125 B
`build/block-library/blocks/comment-content/style-rtl.css`	92 B
`build/block-library/blocks/comment-content/style.css`	92 B
`build/block-library/blocks/comment-template/style-rtl.css`	199 B
`build/block-library/blocks/comment-template/style.css`	198 B
`build/block-library/blocks/comments-pagination-numbers/editor-rtl.css`	123 B
`build/block-library/blocks/comments-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/comments-pagination/editor-rtl.css`	222 B
`build/block-library/blocks/comments-pagination/editor.css`	209 B
`build/block-library/blocks/comments-pagination/style-rtl.css`	235 B
`build/block-library/blocks/comments-pagination/style.css`	231 B
`build/block-library/blocks/comments-title/editor-rtl.css`	75 B
`build/block-library/blocks/comments-title/editor.css`	75 B
`build/block-library/blocks/comments/editor-rtl.css`	840 B
`build/block-library/blocks/comments/editor.css`	839 B
`build/block-library/blocks/comments/style-rtl.css`	637 B
`build/block-library/blocks/comments/style.css`	636 B
`build/block-library/blocks/cover/editor-rtl.css`	647 B
`build/block-library/blocks/cover/editor.css`	650 B
`build/block-library/blocks/cover/style-rtl.css`	1.7 kB
`build/block-library/blocks/cover/style.css`	1.69 kB
`build/block-library/blocks/details/editor-rtl.css`	65 B
`build/block-library/blocks/details/editor.css`	65 B
`build/block-library/blocks/details/style-rtl.css`	98 B
`build/block-library/blocks/details/style.css`	98 B
`build/block-library/blocks/embed/editor-rtl.css`	293 B
`build/block-library/blocks/embed/editor.css`	293 B
`build/block-library/blocks/embed/style-rtl.css`	410 B
`build/block-library/blocks/embed/style.css`	410 B
`build/block-library/blocks/embed/theme-rtl.css`	138 B
`build/block-library/blocks/embed/theme.css`	138 B
`build/block-library/blocks/file/editor-rtl.css`	316 B
`build/block-library/blocks/file/editor.css`	316 B
`build/block-library/blocks/file/style-rtl.css`	280 B
`build/block-library/blocks/file/style.css`	281 B
`build/block-library/blocks/file/view.min.js`	322 B
`build/block-library/blocks/footnotes/style-rtl.css`	201 B
`build/block-library/blocks/footnotes/style.css`	199 B
`build/block-library/blocks/form-input/editor-rtl.css`	229 B
`build/block-library/blocks/form-input/editor.css`	228 B
`build/block-library/blocks/form-input/style-rtl.css`	343 B
`build/block-library/blocks/form-input/style.css`	343 B
`build/block-library/blocks/form-submission-notification/editor-rtl.css`	343 B
`build/block-library/blocks/form-submission-notification/editor.css`	342 B
`build/block-library/blocks/form-submit-button/style-rtl.css`	69 B
`build/block-library/blocks/form-submit-button/style.css`	69 B
`build/block-library/blocks/form/view.min.js`	452 B
`build/block-library/blocks/freeform/editor-rtl.css`	2.61 kB
`build/block-library/blocks/freeform/editor.css`	2.61 kB
`build/block-library/blocks/gallery/editor-rtl.css`	957 B
`build/block-library/blocks/gallery/editor.css`	962 B
`build/block-library/blocks/gallery/style-rtl.css`	1.75 kB
`build/block-library/blocks/gallery/style.css`	1.75 kB
`build/block-library/blocks/gallery/theme-rtl.css`	122 B
`build/block-library/blocks/gallery/theme.css`	122 B
`build/block-library/blocks/group/editor-rtl.css`	654 B
`build/block-library/blocks/group/editor.css`	654 B
`build/block-library/blocks/group/style-rtl.css`	57 B
`build/block-library/blocks/group/style.css`	57 B
`build/block-library/blocks/group/theme-rtl.css`	78 B
`build/block-library/blocks/group/theme.css`	78 B
`build/block-library/blocks/heading/style-rtl.css`	189 B
`build/block-library/blocks/heading/style.css`	189 B
`build/block-library/blocks/html/editor-rtl.css`	340 B
`build/block-library/blocks/html/editor.css`	341 B
`build/block-library/blocks/image/editor-rtl.css`	834 B
`build/block-library/blocks/image/editor.css`	833 B
`build/block-library/blocks/image/style-rtl.css`	1.61 kB
`build/block-library/blocks/image/style.css`	1.6 kB
`build/block-library/blocks/image/theme-rtl.css`	137 B
`build/block-library/blocks/image/theme.css`	137 B
`build/block-library/blocks/image/view.min.js`	2.02 kB
`build/block-library/blocks/latest-comments/style-rtl.css`	357 B
`build/block-library/blocks/latest-comments/style.css`	357 B
`build/block-library/blocks/latest-posts/editor-rtl.css`	213 B
`build/block-library/blocks/latest-posts/editor.css`	212 B
`build/block-library/blocks/latest-posts/style-rtl.css`	478 B
`build/block-library/blocks/latest-posts/style.css`	478 B
`build/block-library/blocks/list/style-rtl.css`	88 B
`build/block-library/blocks/list/style.css`	88 B
`build/block-library/blocks/media-text/editor-rtl.css`	266 B
`build/block-library/blocks/media-text/editor.css`	263 B
`build/block-library/blocks/media-text/style-rtl.css`	505 B
`build/block-library/blocks/media-text/style.css`	503 B
`build/block-library/blocks/more/editor-rtl.css`	431 B
`build/block-library/blocks/more/editor.css`	431 B
`build/block-library/blocks/navigation-link/editor-rtl.css`	671 B
`build/block-library/blocks/navigation-link/editor.css`	672 B
`build/block-library/blocks/navigation-link/style-rtl.css`	103 B
`build/block-library/blocks/navigation-link/style.css`	103 B
`build/block-library/blocks/navigation-submenu/editor-rtl.css`	299 B
`build/block-library/blocks/navigation-submenu/editor.css`	299 B
`build/block-library/blocks/navigation/editor-rtl.css`	2.26 kB
`build/block-library/blocks/navigation/editor.css`	2.26 kB
`build/block-library/blocks/navigation/style-rtl.css`	2.25 kB
`build/block-library/blocks/navigation/style.css`	2.23 kB
`build/block-library/blocks/navigation/view.min.js`	1.1 kB
`build/block-library/blocks/nextpage/editor-rtl.css`	395 B
`build/block-library/blocks/nextpage/editor.css`	395 B
`build/block-library/blocks/page-list/editor-rtl.css`	401 B
`build/block-library/blocks/page-list/editor.css`	401 B
`build/block-library/blocks/page-list/style-rtl.css`	175 B
`build/block-library/blocks/page-list/style.css`	175 B
`build/block-library/blocks/paragraph/editor-rtl.css`	235 B
`build/block-library/blocks/paragraph/editor.css`	235 B
`build/block-library/blocks/paragraph/style-rtl.css`	335 B
`build/block-library/blocks/paragraph/style.css`	335 B
`build/block-library/blocks/post-author/style-rtl.css`	175 B
`build/block-library/blocks/post-author/style.css`	176 B
`build/block-library/blocks/post-comments-form/editor-rtl.css`	96 B
`build/block-library/blocks/post-comments-form/editor.css`	96 B
`build/block-library/blocks/post-comments-form/style-rtl.css`	508 B
`build/block-library/blocks/post-comments-form/style.css`	508 B
`build/block-library/blocks/post-date/style-rtl.css`	61 B
`build/block-library/blocks/post-date/style.css`	61 B
`build/block-library/blocks/post-excerpt/editor-rtl.css`	71 B
`build/block-library/blocks/post-excerpt/editor.css`	71 B
`build/block-library/blocks/post-excerpt/style-rtl.css`	141 B
`build/block-library/blocks/post-excerpt/style.css`	141 B
`build/block-library/blocks/post-featured-image/editor-rtl.css`	666 B
`build/block-library/blocks/post-featured-image/editor.css`	662 B
`build/block-library/blocks/post-featured-image/style-rtl.css`	345 B
`build/block-library/blocks/post-featured-image/style.css`	345 B
`build/block-library/blocks/post-navigation-link/style-rtl.css`	215 B
`build/block-library/blocks/post-navigation-link/style.css`	214 B
`build/block-library/blocks/post-template/editor-rtl.css`	99 B
`build/block-library/blocks/post-template/editor.css`	98 B
`build/block-library/blocks/post-template/style-rtl.css`	409 B
`build/block-library/blocks/post-template/style.css`	408 B
`build/block-library/blocks/post-terms/style-rtl.css`	96 B
`build/block-library/blocks/post-terms/style.css`	96 B
`build/block-library/blocks/post-time-to-read/style-rtl.css`	69 B
`build/block-library/blocks/post-time-to-read/style.css`	69 B
`build/block-library/blocks/post-title/style-rtl.css`	100 B
`build/block-library/blocks/post-title/style.css`	100 B
`build/block-library/blocks/preformatted/style-rtl.css`	125 B
`build/block-library/blocks/preformatted/style.css`	125 B
`build/block-library/blocks/pullquote/editor-rtl.css`	135 B
`build/block-library/blocks/pullquote/editor.css`	135 B
`build/block-library/blocks/pullquote/style-rtl.css`	354 B
`build/block-library/blocks/pullquote/style.css`	354 B
`build/block-library/blocks/pullquote/theme-rtl.css`	168 B
`build/block-library/blocks/pullquote/theme.css`	168 B
`build/block-library/blocks/query-pagination-numbers/editor-rtl.css`	122 B
`build/block-library/blocks/query-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/query-pagination/editor-rtl.css`	221 B
`build/block-library/blocks/query-pagination/editor.css`	211 B
`build/block-library/blocks/query-pagination/style-rtl.css`	288 B
`build/block-library/blocks/query-pagination/style.css`	284 B
`build/block-library/blocks/query-title/style-rtl.css`	63 B
`build/block-library/blocks/query-title/style.css`	63 B
`build/block-library/blocks/query/editor-rtl.css`	486 B
`build/block-library/blocks/query/editor.css`	486 B
`build/block-library/blocks/query/style-rtl.css`	312 B
`build/block-library/blocks/query/style.css`	308 B
`build/block-library/blocks/query/view.min.js`	647 B
`build/block-library/blocks/quote/style-rtl.css`	237 B
`build/block-library/blocks/quote/style.css`	237 B
`build/block-library/blocks/quote/theme-rtl.css`	223 B
`build/block-library/blocks/quote/theme.css`	226 B
`build/block-library/blocks/read-more/style-rtl.css`	140 B
`build/block-library/blocks/read-more/style.css`	140 B
`build/block-library/blocks/rss/editor-rtl.css`	149 B
`build/block-library/blocks/rss/editor.css`	149 B
`build/block-library/blocks/rss/style-rtl.css`	289 B
`build/block-library/blocks/rss/style.css`	288 B
`build/block-library/blocks/search/editor-rtl.css`	184 B
`build/block-library/blocks/search/editor.css`	184 B
`build/block-library/blocks/search/style-rtl.css`	602 B
`build/block-library/blocks/search/style.css`	602 B
`build/block-library/blocks/search/theme-rtl.css`	114 B
`build/block-library/blocks/search/theme.css`	114 B
`build/block-library/blocks/search/view.min.js`	475 B
`build/block-library/blocks/separator/editor-rtl.css`	146 B
`build/block-library/blocks/separator/editor.css`	146 B
`build/block-library/blocks/separator/style-rtl.css`	234 B
`build/block-library/blocks/separator/style.css`	234 B
`build/block-library/blocks/separator/theme-rtl.css`	194 B
`build/block-library/blocks/separator/theme.css`	194 B
`build/block-library/blocks/shortcode/editor-rtl.css`	329 B
`build/block-library/blocks/shortcode/editor.css`	329 B
`build/block-library/blocks/site-logo/editor-rtl.css`	760 B
`build/block-library/blocks/site-logo/editor.css`	760 B
`build/block-library/blocks/site-logo/style-rtl.css`	204 B
`build/block-library/blocks/site-logo/style.css`	204 B
`build/block-library/blocks/site-tagline/editor-rtl.css`	86 B
`build/block-library/blocks/site-tagline/editor.css`	86 B
`build/block-library/blocks/site-title/editor-rtl.css`	116 B
`build/block-library/blocks/site-title/editor.css`	116 B
`build/block-library/blocks/site-title/style-rtl.css`	57 B
`build/block-library/blocks/site-title/style.css`	57 B
`build/block-library/blocks/social-link/editor-rtl.css`	184 B
`build/block-library/blocks/social-link/editor.css`	184 B
`build/block-library/blocks/social-links/editor-rtl.css`	682 B
`build/block-library/blocks/social-links/editor.css`	681 B
`build/block-library/blocks/social-links/style-rtl.css`	1.49 kB
`build/block-library/blocks/social-links/style.css`	1.49 kB
`build/block-library/blocks/spacer/editor-rtl.css`	359 B
`build/block-library/blocks/spacer/editor.css`	359 B
`build/block-library/blocks/spacer/style-rtl.css`	48 B
`build/block-library/blocks/spacer/style.css`	48 B
`build/block-library/blocks/table/editor-rtl.css`	395 B
`build/block-library/blocks/table/editor.css`	395 B
`build/block-library/blocks/table/style-rtl.css`	646 B
`build/block-library/blocks/table/style.css`	645 B
`build/block-library/blocks/table/theme-rtl.css`	157 B
`build/block-library/blocks/table/theme.css`	157 B
`build/block-library/blocks/tag-cloud/style-rtl.css`	251 B
`build/block-library/blocks/tag-cloud/style.css`	253 B
`build/block-library/blocks/template-part/editor-rtl.css`	403 B
`build/block-library/blocks/template-part/editor.css`	403 B
`build/block-library/blocks/template-part/theme-rtl.css`	101 B
`build/block-library/blocks/template-part/theme.css`	101 B
`build/block-library/blocks/term-description/style-rtl.css`	111 B
`build/block-library/blocks/term-description/style.css`	111 B
`build/block-library/blocks/text-columns/editor-rtl.css`	95 B
`build/block-library/blocks/text-columns/editor.css`	95 B
`build/block-library/blocks/text-columns/style-rtl.css`	166 B
`build/block-library/blocks/text-columns/style.css`	166 B
`build/block-library/blocks/verse/style-rtl.css`	99 B
`build/block-library/blocks/verse/style.css`	99 B
`build/block-library/blocks/video/editor-rtl.css`	552 B
`build/block-library/blocks/video/editor.css`	555 B
`build/block-library/blocks/video/style-rtl.css`	191 B
`build/block-library/blocks/video/style.css`	191 B
`build/block-library/blocks/video/theme-rtl.css`	139 B
`build/block-library/blocks/video/theme.css`	139 B
`build/block-library/classic-rtl.css`	179 B
`build/block-library/classic.css`	179 B
`build/block-library/common-rtl.css`	1.11 kB
`build/block-library/common.css`	1.11 kB
`build/block-library/editor-elements-rtl.css`	75 B
`build/block-library/editor-elements.css`	75 B
`build/block-library/editor-rtl.css`	12.3 kB
`build/block-library/editor.css`	12.3 kB
`build/block-library/elements-rtl.css`	54 B
`build/block-library/elements.css`	54 B
`build/block-library/index.min.js`	215 kB
`build/block-library/reset-rtl.css`	472 B
`build/block-library/reset.css`	472 B
`build/block-library/style-rtl.css`	14.7 kB
`build/block-library/style.css`	14.7 kB
`build/block-library/theme-rtl.css`	700 B
`build/block-library/theme.css`	705 B
`build/block-serialization-default-parser/index.min.js`	1.13 kB
`build/block-serialization-spec-parser/index.min.js`	2.87 kB
`build/blocks/index.min.js`	51.6 kB
`build/commands/index.min.js`	15.5 kB
`build/commands/style-rtl.css`	947 B
`build/commands/style.css`	942 B
`build/components/index.min.js`	235 kB
`build/components/style-rtl.css`	12.1 kB
`build/components/style.css`	12.1 kB
`build/compose/index.min.js`	12.8 kB
`build/core-commands/index.min.js`	2.73 kB
`build/core-data/index.min.js`	72.7 kB
`build/customize-widgets/index.min.js`	12.1 kB
`build/customize-widgets/style-rtl.css`	1.36 kB
`build/customize-widgets/style.css`	1.36 kB
`build/data-controls/index.min.js`	651 B
`build/date/index.min.js`	17.9 kB
`build/deprecated/index.min.js`	462 B
`build/dom-ready/index.min.js`	336 B
`build/dom/index.min.js`	4.69 kB
`build/edit-post/classic-rtl.css`	571 B
`build/edit-post/classic.css`	571 B
`build/edit-post/index.min.js`	24.9 kB
`build/edit-post/style-rtl.css`	5.68 kB
`build/edit-post/style.css`	5.68 kB
`build/edit-site/index.min.js`	195 kB
`build/edit-site/style-rtl.css`	15.1 kB
`build/edit-site/style.css`	15.1 kB
`build/edit-widgets/index.min.js`	17.4 kB
`build/edit-widgets/style-rtl.css`	4.44 kB
`build/edit-widgets/style.css`	4.43 kB
`build/editor/index.min.js`	61.7 kB
`build/editor/style-rtl.css`	5.48 kB
`build/editor/style.css`	5.48 kB
`build/element/index.min.js`	4.87 kB
`build/escape-html/index.min.js`	548 B
`build/format-library/index.min.js`	7.98 kB
`build/format-library/style-rtl.css`	500 B
`build/format-library/style.css`	500 B
`build/hooks/index.min.js`	1.57 kB
`build/html-entities/index.min.js`	454 B
`build/i18n/index.min.js`	3.61 kB
`build/interactivity/file.min.js`	442 B
`build/interactivity/image.min.js`	2.15 kB
`build/interactivity/navigation.min.js`	1.23 kB
`build/interactivity/query.min.js`	791 B
`build/interactivity/search.min.js`	610 B
`build/is-shallow-equal/index.min.js`	535 B
`build/keyboard-shortcuts/index.min.js`	1.76 kB
`build/keycodes/index.min.js`	1.49 kB
`build/list-reusable-blocks/index.min.js`	2.11 kB
`build/list-reusable-blocks/style-rtl.css`	865 B
`build/list-reusable-blocks/style.css`	865 B
`build/media-utils/index.min.js`	2.92 kB
`build/modules/importmap-polyfill.min.js`	12.2 kB
`build/notices/index.min.js`	964 B
`build/nux/index.min.js`	2.01 kB
`build/nux/style-rtl.css`	775 B
`build/nux/style.css`	771 B
`build/patterns/index.min.js`	5.37 kB
`build/patterns/style-rtl.css`	564 B
`build/patterns/style.css`	564 B
`build/plugins/index.min.js`	1.81 kB
`build/preferences-persistence/index.min.js`	2.08 kB
`build/preferences/index.min.js`	2.52 kB
`build/preferences/style-rtl.css`	725 B
`build/preferences/style.css`	728 B
`build/primitives/index.min.js`	994 B
`build/priority-queue/index.min.js`	1.52 kB
`build/private-apis/index.min.js`	1.02 kB
`build/react-i18n/index.min.js`	631 B
`build/react-refresh-entry/index.min.js`	9.46 kB
`build/react-refresh-runtime/index.min.js`	6.78 kB
`build/redux-routine/index.min.js`	2.71 kB
`build/reusable-blocks/index.min.js`	2.74 kB
`build/reusable-blocks/style-rtl.css`	265 B
`build/reusable-blocks/style.css`	265 B
`build/rich-text/index.min.js`	10.4 kB
`build/router/index.min.js`	1.79 kB
`build/server-side-render/index.min.js`	1.96 kB
`build/shortcode/index.min.js`	1.4 kB
`build/style-engine/index.min.js`	2.06 kB
`build/token-list/index.min.js`	587 B
`build/url/index.min.js`	3.83 kB
`build/vendors/inert-polyfill.min.js`	2.48 kB
`build/vendors/react-dom.min.js`	41.8 kB
`build/vendors/react.min.js`	4.02 kB
`build/viewport/index.min.js`	967 B
`build/warning/index.min.js`	259 B
`build/widgets/index.min.js`	7.22 kB
`build/widgets/style-rtl.css`	1.18 kB
`build/widgets/style.css`	1.18 kB
`build/wordcount/index.min.js`	1.03 kB

_{compressed-size-action}

jsnajdr

Nice, that was easier than I expected 😄

packages/data/src/test/factory.js

packages/data/src/factory.js

Data: fix memoized createRegistrySelector

a9e6f53

ellatrix added the [Package] Data /packages/data label Jan 16, 2024

ellatrix requested a review from nerrad as a code owner January 16, 2024 15:50

ellatrix requested a review from jsnajdr January 16, 2024 15:50

Remove accidental add

5cc3b87

ellatrix added the [Type] Bug An existing feature does not function as intended label Jan 16, 2024

jsnajdr approved these changes Jan 16, 2024

View reviewed changes

packages/data/src/test/factory.js Outdated Show resolved Hide resolved

packages/data/src/factory.js Outdated Show resolved Hide resolved

ellatrix added 2 commits January 16, 2024 21:01

Address feedback, fix e2e tests

a19edd1

Avoid test changes

238cbd6

ellatrix enabled auto-merge (squash) January 16, 2024 20:14

ellatrix merged commit 56c02a0 into trunk Jan 16, 2024

ellatrix deleted the try/fix-memoed-registry-selector branch January 16, 2024 20:35

github-actions bot added this to the Gutenberg 17.6 milestone Jan 16, 2024

This was referenced Jan 19, 2024

Patterns: avoid fetching on load #57929

Closed

Patterns: avoid fetching on load #57997

Closed

Patterns: avoid fetching on load #57999

Merged

jsnajdr mentioned this pull request Feb 26, 2024

Fix DisableNonPageContentBlocks #59297

Merged

Mamaduka mentioned this pull request Mar 20, 2024

Editor: Memoize 'getInsertionPoint' selector #60015

Merged

This was referenced Jul 10, 2024

Widgets: Memoize 'getWidgets' store selector #63338

Merged

Block Directory: Memoize store selectors #63346

Merged

Mamaduka mentioned this pull request Jul 23, 2024

Fix: Error while Calling edit-site getCurrentTemplateTemplateParts selector #63818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Data: fix memoized createRegistrySelector #57888

Data: fix memoized createRegistrySelector #57888

Uh oh!

ellatrix commented Jan 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 16, 2024 •

edited

Loading

Uh oh!

jsnajdr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	export const getNewBlockTypes = createRegistrySelector(
	( select ) => ( state ) => {
	const usedBlockTree = select( blockEditorStore ).getBlocks();
	const installedBlockTypes = getInstalledBlockTypes( state );

	return installedBlockTypes.filter( ( blockType ) =>
	hasBlockType( blockType, usedBlockTree )
	);
	}
	);

	export const getUnusedBlockTypes = createRegistrySelector(
	( select ) => ( state ) => {
	const usedBlockTree = select( blockEditorStore ).getBlocks();
	const installedBlockTypes = getInstalledBlockTypes( state );

	return installedBlockTypes.filter(
	( blockType ) => ! hasBlockType( blockType, usedBlockTree )
	);
	}
	);

	export const getCurrentTemplateTemplateParts = createRegistrySelector(
	( select ) => () => {
	const templateParts = select( coreDataStore ).getEntityRecords(
	'postType',
	TEMPLATE_PART_POST_TYPE,
	{ per_page: -1 }
	);

	const clientIds =
	select( blockEditorStore ).__experimentalGetGlobalBlocksByName(
	'core/template-part'
	);
	const blocks =
	select( blockEditorStore ).getBlocksByClientId( clientIds );

	return getFilteredTemplatePartBlocks( blocks, templateParts );
	}
	);

	export const getInsertionPoint = createRegistrySelector(
	( select ) => ( state ) => {
	if ( typeof state.blockInserterPanel === 'object' ) {
	return state.blockInserterPanel;
	}

	if ( getRenderingMode( state ) === 'template-locked' ) {
	const [ postContentClientId ] =
	select( blockEditorStore ).__experimentalGetGlobalBlocksByName(
	'core/post-content'
	);
	if ( postContentClientId ) {
	return {
	rootClientId: postContentClientId,
	insertionIndex: undefined,
	filterValue: undefined,
	};
	}
	}

	return EMPTY_INSERTION_POINT;
	}
	);

	export const getWidgets = createRegistrySelector( ( select ) => () => {
	const widgets = select( coreStore ).getEntityRecords(
	'root',
	'widget',
	buildWidgetsQuery()
	);

	return (
	// Key widgets by their ID.
	widgets?.reduce(
	( allWidgets, widget ) => ( {
	...allWidgets,
	[ widget.id ]: widget,
	} ),
	{}
	) \|\| {}
	);
	} );

	const selectUserPatterns = createSelector(
	( select, syncStatus, search = '' ) => {
	const { getEntityRecords, getIsResolving, getUserPatternCategories } =
	select( coreStore );

	const query = { per_page: -1 };
	const records = getEntityRecords(
	'postType',
	PATTERN_TYPES.user,
	query
	);
	const userPatternCategories = getUserPatternCategories();
	const categories = new Map();
	userPatternCategories.forEach( ( userCategory ) =>
	categories.set( userCategory.id, userCategory )
	);
	let patterns = records
	? records.map( ( record ) =>
	patternBlockToPattern( record, categories )
	)
	: EMPTY_PATTERN_LIST;

	const isResolving = getIsResolving( 'getEntityRecords', [
	'postType',
	PATTERN_TYPES.user,
	query,
	] );

	if ( syncStatus ) {
	patterns = patterns.filter(
	( pattern ) => pattern.syncStatus === syncStatus
	);
	}

	patterns = searchItems( patterns, search, {
	// We exit user pattern retrieval early if we aren't in the
	// catch-all category for user created patterns, so it has
	// to be in the category.
	hasCategory: () => true,
	} );

	return {
	patterns,
	isResolving,
	categories: userPatternCategories,
	};
	},
	( select ) => [
	select( coreStore ).getEntityRecords( 'postType', PATTERN_TYPES.user, {
	per_page: -1,
	} ),
	select( coreStore ).getIsResolving( 'getEntityRecords', [
	'postType',
	PATTERN_TYPES.user,
	{ per_page: -1 },
	] ),
	select( coreStore ).getUserPatternCategories(),
	]
	);

Data: fix memoized createRegistrySelector #57888

Data: fix memoized createRegistrySelector #57888

Uh oh!

Conversation

ellatrix commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Uh oh!

github-actions bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsnajdr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellatrix commented Jan 16, 2024 •

edited

Loading

github-actions bot commented Jan 16, 2024 •

edited

Loading