Font Library: Resolve an issue where a border was appearing even when no fonts were available. #57371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @HrithikDalal! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Thanks for contributing, @HrithikDalal! It looks like the linked issue has been resolved. I'm going to close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug where, If the currently active theme does not define fonts, an unnatural border is displayed.
Why?
Issue Reference - #54527
How?
I've implemented a check in the code. Now the Font Listing will be displayed only when fonts are available. Otherwise, a message will be displayed stating 'No fonts available.'
Testing Instructions
Screenshots or screencast
Before -
After -
When fonts are available. (No change)
