Skip to content

Revert "DropdownMenu V2: add support for rendering in legacy popover slot" #56484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

Revert "DropdownMenu V2: add support for rendering in legacy popover slot" #56484

merged 1 commit into from
Nov 23, 2023

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Nov 23, 2023 •
edited
Loading

Reverts #56342 following what decided in #56482

If needed, we can expose the portal and portalElement props directly.

@ciampo ciampo requested a review from ajitbohra as a code owner November 23, 2023 16:33
@ciampo ciampo requested a review from tyxla November 23, 2023 16:34
@ciampo ciampo self-assigned this Nov 23, 2023
@ciampo ciampo added [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality labels Nov 23, 2023
tyxla
tyxla approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we made an informed decision 👍

@ciampo ciampo enabled auto-merge (squash) November 23, 2023 16:42
@ciampo ciampo merged commit fc5619d into trunk Nov 23, 2023
@ciampo ciampo deleted the revert-56342-feat/dropdown-menu-v2-ariakit-slotfill branch November 23, 2023 17:02
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ciampo ciampo

Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ciampo @tyxla