Fix: Theme.json font settings in unit test #56309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/class-wp-theme-json-test.php |
glendaviesnz
approved these changes
Nov 20, 2023
|
Nice tidy-up removing that nesting, I didn't notice that. Tests still passing for me if you want to merge. |
|
Backport PR available in: WordPress/wordpress-develop#5942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the font settings clearer in the main theme.json test (
test_get_stylesheet).Why?
I couldn't work out if the existing font settings were a mistake or if they were in fact trying to configure font families as if they were font sizes. It's probably best to define both font size and font family configurations for better coverage anyhow.
How?
settings.typography.fontFamiliesand introducessettings.typography.fontSizesTesting Instructions
npm run test:unit:php:base -- --filter WP_Theme_JSON_Gutenberg_TestScreenshots or screencast