Tabs: cleanup and improvements #56224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c959cd1 to
8be2a47
Compare
|
Flaky tests detected in 34ae69d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6897370662
|
22ebe28 to
3d3588d
Compare
ciampo
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A few small updates to the
Tabscomponent family:useTabContext()consistently, instead of sometimes usinguseContext()Tabs.ContextWhy?
These are items that came up while working on other things. While they could be broken into their own separate PRs, they felt small enough to batch together. More specifically:
useTabContext()
No change in behavior here, it just wasn't being used consistently
Memoize context value
Was causing unnecessary re-renders.
Expose
Tabs.ContextIn some implications involving
slot/fills, it's necessary to wrap subcomponents in an additional context provider. See #55360 for a real-life example. This also meant updating the warning thrown when context is missing to include the possibility of using aTabs.Context.ProviderAdd sub-components to Storybook
I forgot them initially, but now they can be viewed in the component docs in Storybook.
Testing Instructions
N/A, other than making sure all the tests pass.