Migrate keyboard-navigable-blocks e2e tests from puppeteer to playwright #54944
+276
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +177 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
The tests pass and the code makes sense to me but I'll let someone with more experience approve. |
Mamaduka
reviewed
Oct 2, 2023
test/e2e/specs/editor/various/keyboard-navigable-blocks.spec.js
Outdated
Show resolved
Hide resolved
|
Thank you, @jeryj! Currently, the test produced ESLint warnings for We might want to refactor the test a bit to satisfy this rule or ignore it at the file level. P.S. If you have an ESLint add-on, then it makes really annoying viewing the test file 😅 How to testScreenshot |
Mamaduka
reviewed
Oct 2, 2023
test/e2e/specs/editor/various/keyboard-navigable-blocks.spec.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
Oct 2, 2023
Comment on lines
+205
to
+214
| const ariaLabel = await this.page.evaluate( () => { | ||
| const { activeElement } = | ||
| document.activeElement.contentDocument ?? document; | ||
| return ( | ||
| activeElement.getAttribute( 'aria-label' ) || | ||
| activeElement.innerText | ||
| ); | ||
| } ); | ||
|
|
||
| expect( ariaLabel ).toBe( label ); |
There was a problem hiding this comment.
Btw, the page.locator( ':focus' ) or editor.canvas.locator( ':focus' ) can be used for locating active elements.
There was a problem hiding this comment.
I tried refactoring this to use :focus but couldn't get the tests to pass. The conditional of checking either the aria label or the innerText was getting in the way. If there was a toHaveAccessibleName() check, that would be really useful, but I couldn't find a good way of doing that.
There was a problem hiding this comment.
Thank you, @jeryj. It makes sense.
- Disable expect/expect - Use :focus locator where possible
|
Thank you for the review, @Mamaduka! I've addressed the feedback as best I could. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrating keyboard-navigable-blocks e2e tests from puppeteer to playwright
Why?
Part of the larger migration effort in #38851, also because I'm going to be modifying this test as part of #54513 and figured I may as well migrate it before making changes.
How?
Followed the migration guide.
Testing Instructions
npm run test:e2e:playwright -- editor/various/keyboard-navigable-blocks.spec.js