Plugin: Remove legacy logic for '__unstableResolvedAssets' setting #54812
Conversation
|
|
||
| if ( 'site-editor.php' === $pagenow ) { | ||
| wp_enqueue_style( 'wp-edit-site' ); | ||
| } |
There was a problem hiding this comment.
For reference: The updated version of this function removes these lines.
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.3/script-loader.php |
b0eb26e to
f993463
Compare
There was a problem hiding this comment.
Thanks for tidying this up @Mamaduka!
✅ Removal looks safe since the value was always being overridden on this line, irrespective of which WP version is running:
✅ Smoke tested styles in the editor and site editor while running WP 6.3
✅ Smoke tested styles in the editor and site editor while running WP 6.4
LGTM! ✨
|
Thanks for testing and review, @andrewserong 🙇 |
What?
This is similar to #51100.
Removes legacy logic from the
__unstableResolvedAssetssetting from the WP 6.3 compat folder.Why?
The same logic is already handled by the
_gutenberg_get_iframed_editor_assets_6_4in thelib/compat/wordpress-6.4/script-loader.phpdirectory, which overrides legacy settings. There's no need to run asset generation twice.Ref: #54254.
Testing Instructions
Verify iframe-related test pass. Smoke test the editors and asset loading.