Background image block support: Add tests, adjust injection logic slightly #54489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #54336
Add PHP tests for the background image block support.
Also, adjust the style injection slightly, so that if the existing style attribute ends in a semi-colon, we still inject the newly created styles.
Why?
While working on the backport for the background image block support over in WordPress/wordpress-develop#5209, I added some tests, and noticed the logic for injecting the style tag needed adjusting slightly. While in Gutenberg, inline styles don't include a trailing semi-colon, I thought it'd be good to factor it in, just in case, for the future reliability of the support and interacting with other styles.
Also, it's good to add tests for features!
How?
Testing Instructions
npm run test:unit:php:base -- --filter WP_Block_Supports_Background_Test
locally to confirm.